Upgrade go to 1.6.2

added TorBrowserTeam201605R component::applications/tor browser owner::dcf priority::medium resolution::fixed severity::normal status::closed tbb-gitian type::task labels

Trac:
Keywords: N/A deleted, tbb-gitian added
Cc: N/A to gk

Eventually I'll need a newer version of Go (in particular when I integrate the next PT).

Trac:
Reviewer: N/A to N/A
Cc: gk to gk, yawning

Here is a draft patch: 0001-Upgrade-go-to-1.6.patch The patch is untested because I'm having trouble building Tor Browser right now. I thought I'd drop the patch rather than struggle more with Gitian. It illustrates the idea: first you build a go 1.4, then you use it to bootstrap a go 1.6.

Also, the patch should not be applied right away; that's because a security release, 1.6.1, is scheduled for two days hence. There is also supposed to be a non-security 1.6.2 release following.

Trac:
0001-Upgrade-go-to-1.6.patch

Trac:
0001-Upgrade-go-to-1.6.1.patch

Here's a better-tested patch (previous one didn't work). I managed to get a Tor Browser nightly partially built. It's working for linux but something is wrong with the Ubuntu containers so I haven't been able to try mac and windows yet. 0001-Upgrade-go-to-1.6.1.patch This patch uses the now-released 1.6.1.

Trac:
Summary: Upgrade go to 1.6 to Upgrade go to 1.6.1

Trac:
0001-Upgrade-go-to-1.6.2.patch

Here's a tested patch. I tested it by bootstrapping with obfs4 on linux, mac, and windows. 0001-Upgrade-go-to-1.6.2.patch I put temporary bundles at https://people.torproject.org/~dcf/pt-bundle/bug18333-1/.

The biggest change in the patch is that we now make a shell script containing the CFLAGS and LDFLAGS needed for cross-compilation. The build system in recent versions of Go strips off arguments from CC, which is where we used to pass CFLAGS and LDFLAGS: https://github.com/golang/go/issues/15457.

Trac:
Status: new to needs_review
Summary: Upgrade go to 1.6.1 to Upgrade go to 1.6.2
Keywords: tbb-gitian deleted, tbb-gitian TorBrowserTeam201604R added