#18333 closed task (fixed)

Upgrade go to 1.6.2

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201605R
Cc: gk, yawning Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Release notes: https://golang.org/doc/go1.6
It's not a security requirement or anything, but we're currently on 1.4.3 and don't want to fall too far behind.

Child Tickets

Attachments (3)

0001-Upgrade-go-to-1.6.patch (18.5 KB) - added by dcf 21 months ago.
0001-Upgrade-go-to-1.6.1.patch (18.1 KB) - added by dcf 20 months ago.
0001-Upgrade-go-to-1.6.2.patch (18.9 KB) - added by dcf 20 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 22 months ago by gk

Cc: gk added
Keywords: tbb-gitian added

comment:2 Changed 21 months ago by yawning

Cc: yawning added

Eventually I'll need a newer version of Go (in particular when I integrate the next PT).

comment:3 Changed 21 months ago by dcf

Here is a draft patch:

attachment:0001-Upgrade-go-to-1.6.patch

The patch is untested because I'm having trouble building Tor Browser right now. I thought I'd drop the patch rather than struggle more with Gitian. It illustrates the idea: first you build a go 1.4, then you use it to bootstrap a go 1.6.

Also, the patch should not be applied right away; that's because a security release, 1.6.1, is scheduled for two days hence. There is also supposed to be a non-security 1.6.2 release following.

Changed 21 months ago by dcf

Changed 20 months ago by dcf

comment:4 Changed 20 months ago by dcf

Summary: Upgrade go to 1.6Upgrade go to 1.6.1

Here's a better-tested patch (previous one didn't work). I managed to get a Tor Browser nightly partially built. It's working for linux but something is wrong with the Ubuntu containers so I haven't been able to try mac and windows yet.

attachment:0001-Upgrade-go-to-1.6.1.patch

This patch uses the now-released 1.6.1.

Changed 20 months ago by dcf

comment:5 Changed 20 months ago by dcf

Keywords: TorBrowserTeam201604R added
Status: newneeds_review
Summary: Upgrade go to 1.6.1Upgrade go to 1.6.2

Here's a tested patch. I tested it by bootstrapping with obfs4 on linux, mac, and windows.

attachment:0001-Upgrade-go-to-1.6.2.patch

I put temporary bundles at https://people.torproject.org/~dcf/pt-bundle/bug18333-1/.

The biggest change in the patch is that we now make a shell script containing the CFLAGS and LDFLAGS needed for cross-compilation. The build system in recent versions of Go strips off arguments from CC, which is where we used to pass CFLAGS and LDFLAGS: https://github.com/golang/go/issues/15457.

comment:6 Changed 20 months ago by gk

Do you need that for the upcoming 6.0 stable series or would it be enough if we start shipping that in 6.5x?

comment:7 in reply to:  6 Changed 20 months ago by dcf

Replying to gk:

Do you need that for the upcoming 6.0 stable series or would it be enough if we start shipping that in 6.5x?

It's not needed for 6.0.

comment:8 Changed 20 months ago by gk

Keywords: TorBrowserTeam201605R added; TorBrowserTeam201604R removed

Moving reviews over to May 2016

comment:9 Changed 19 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master: commit 778fd2d07bc40c0458ad7a477b6079a99305071d, thanks.

Note: See TracTickets for help on using tickets.