Opened 4 years ago

Closed 2 years ago

#18354 closed defect (fixed)

flush cached host_name on IP change

Reported by: cypherpunks Owned by:
Priority: Low Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: tyseom Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

description (somehow) implies that the host_name field is reset on IP change:

Host name as found in a reverse DNS lookup of the relay IP address. This field is updated at most once in 12 hours, unless the relay IP address changes. Omitted if the relay IP address was not looked up or if no lookup request was successful yet. 

this would make sense but that does not seem to be the case:

+-----------------+-----------------+
| IP              | host_name       |
+-----------------+-----------------+
| 162.218.239.125 | 162.218.233.43  |
| 160.166.216.122 | 160.163.106.82  |
| 198.96.94.98    | 155.94.246.179  |
| 198.96.94.122   | 155.94.246.178  |
| 197.242.119.107 | 154.118.35.110  |
| 151.20.142.35   | 151.64.24.192   |
| 151.45.92.96    | 151.45.211.193  |
| 178.33.156.144  | 149.202.233.205 |
| 129.21.101.45   | 129.21.102.240  |
| 117.254.79.156  | 117.252.95.186  |
| 104.192.0.18    | 104.192.0.22    |
| 103.44.149.45   | 103.44.149.43   |

Additionally:
I would suggest to omit the host_name record if IP == host_name (saves space).

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by tyseom

Cc: tyseom added

comment:2 Changed 4 years ago by karsten

This should, in theory, already be fixed by #18270. I deployed that fix on onionoo.torproject.org 6 days ago and on onionoo.thecthulhu.com today. If you used data from the former, would you mind looking again if the problem still persists? If it does, let me try harder to fix it.

Omitting the host_name field if it's identical to the IP address would mean that we'd lose the ability to distinguish "no result" from "equivalent to IP address". It's also not that many bytes that we'd save there. I'd say it's not worth the effort.

comment:3 Changed 4 years ago by cypherpunks

Here a few examples, that still have outdated host_name records:

https://onionoo.torproject.org/details?search=198.96.94.122

+-----------------+-----------------+
| IP              | host_name       |
+-----------------+-----------------+
| 104.192.0.18    | 104.192.0.22    |
| 151.50.12.179   | 151.45.75.241   |
| 151.54.1.98     | 151.54.119.132  |
| 198.96.94.122   | 155.94.246.178  |
| 79.111.10.241   | 176.194.103.233 |
| 95.52.36.201    | 178.68.115.116  |

comment:4 Changed 2 years ago by karsten

Resolution: fixed
Status: newclosed

I just checked again and couldn't find a single relay with an IP address in the "host_name" field that did not match an entry in "onion_addresses". Maybe the examples given in comment 3 above came from non-running relays. Closing as fixed.

Note: See TracTickets for help on using tickets.