HiddenServicePort IPv6 broken

Hi,

In reference to: #6551 (moved) and #12670 (moved).

I was not having much luck setting up a Hidden Service. I found later that worked when I used 127.0.0.1:80 instead of [::1]:80.

I then tested v6 and v4, side-by-side: HiddenServicePort 80 127.0.0.1:80 HiddenServicePort 81 [::1]:80

Port 80 worked, 81 did not. I checked a few times with curl locally and with tor browser.

I'm running FreeBSD 10.2. Had a pretty slim configuration when I tried this. Verified with fetch and sockstat that indeed the service was listening on ::1 (::0/0, actually).

Thank you, Teran

Trac:
Username: sega01

changed milestone to %Tor: 0.2.9.x-final

added actualpoints::.1 component::core tor/tor ipv6 milestone::Tor: 0.2.9.x-final owner::nickm points::0.5 priority::medium reporter::sega01 resolution::fixed review-group-10 severity::normal sponsor::R-can status::closed tor-hs type::defect version::tor 0.2.6.10 labels

When I run:

nc -l -4 8080

nc -l -6 8080

mkdir -p /tmp/tor.$$/hs
chmod go-rwx /tmp/tor.$$/hs
src/or/tor SOCKSPort 0 DataDirectory /tmp/tor.$$ HiddenServiceDir /tmp/tor.$$/hs HiddenServicePort "80 127.0.0.1:8080" HiddenServicePort "81 [::1]:8080"

I can connect via port 80, but not via port 81. I wonder whether I have made some IPv6-specific configuration error, or whether it really doesn't work in 0.2.6.10.

Trac:
Keywords: N/A deleted, ipv6 added
Milestone: N/A to Tor: 0.2.9.x-final

Trac:
Sponsor: N/A to SponsorR-can
Reviewer: N/A to N/A

Trac:
Points: N/A to small/medium

Trac:
Keywords: N/A deleted, tor-hs added

tickets market to be removed from milestone 029

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.???

This doesn't work on any tor version I've tried on OS X or Linux. I suspect IPv6 HiddenServicePort was never implemented correctly.

I can confirm that IPv6 HiddenServicePort doesn't work on 0.2.8.7 when the backend server is:

nc -l ::1 1234

But it does work when the HiddenServicePort is explicit or implicit IPv4 127.0.0.1, and the backend server is:

nc -l 127.0.0.1 1234

I also tested this with Tor 0.2.7.6, and it doesn't work. I suspect it's likely this has never worked as documented, and that a good workaround is to use an IPv4 or unix socket HiddenServicePort.

We should add a chutney test for this when we fix it, so it doesn't break and remain unnoticed, see #20142 (moved).

Moving to 0.2.9 as the duplicate #20127 (moved) was in 0.2.9.

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.2.9.x-final
Points: small/medium to 0.5
Summary: HiddenServicePort IPv6 broken on FreeBSD to HiddenServicePort IPv6 broken

I think that the problem lies in the test in conmnection_exit_connect(). The parentheses are wrong. We should allow rendezvous connections to IPv6 addresses even when IPv6Exit is false, right?

I've tried rewriting this test to be correct and easier to read; please review and test my branch bug18357?

(This code is not tested.)

Trac:
Owner: N/A to nickm
Status: new to accepted
Actualpoints: N/A to .1

Trac:
Status: accepted to needs_review

Add needs_review 0.2.9 tickets, plus ones that have been in needs_revision for less than a week, to review-group-10.

Trac:
Keywords: N/A deleted, review-group-10 added

Just tested this patch and it seems to work!

That is, with master I could not connect to an HS that was pointing to [::1]:80, but when I used nick's branch it worked fine. An HS pointing to 127.0.0.1:80 worked fine in both cases.

Some nitpicking: I kind of feel like this exit policy matching thing deserves its own function. And the chutney tests (or even unittests) that teor suggested would be a nice addition I guess.

Other than those metacomments above, the branch seems to work fine. Feel free to toggle merge_ready.

I kind of feel like this exit policy matching thing deserves its own function.

Thanks for the review! I've extracted the exit policy thing into a new function and merged.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

changed time estimate to 4h

added 48m of time spent

mentioned in issue #20127 (moved)

mentioned in issue #20142 (moved)

mentioned in issue tpo/core/chutney#20142

moved to tpo/core/tor#18357 (closed)