Opened 3 years ago

Closed 3 years ago

#18368 closed defect (fixed)

Don't call a consensus a "vote" in log messages

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: must-fix-before-028-rc 027-backport
Cc: Actual Points:
Parent ID: #17668 Points:
Reviewer: Sponsor:

Description

This confused me on early attempts to diagnose #17668

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by nickm

Status: acceptedneeds_review

I have a patch for this as part of my branch ed25519_voting_fixes.

comment:3 Changed 3 years ago by nickm

Keywords: must-fix-before-028-rc added
Milestone: Tor: 0.2.7.x-final

These are backportable, but they are tied to the 0.2.8 rc.

comment:4 Changed 3 years ago by sysrqb

The comment in src/or/dircollate.h seems like it has an extraneous "an", and this ticket's title seems different from the patch. Unrelatedly, the \file and \brief in dircolate.h are wrong.

Other than those, it looks good to me. At least within the local functions these changes seems good, but I didn't re-read through all the voting logic to make sure nothing was missed and I didn't test this.

comment:5 Changed 3 years ago by nickm

Added a fixup commit for the comment issues.

comment:6 Changed 3 years ago by nickm

Keywords: 027-backport added
Milestone: Tor: 0.2.8.x-final

comment:7 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

These are now merged into maint-0.2.7 and forwards.

Note: See TracTickets for help on using tickets.