Opened 5 years ago

Closed 5 years ago

#18377 closed defect (fixed)

connection_free_ of NULL dir_connection_t in test_dir_handle_get_status_vote_next_consensus_signatures_not_found

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: test-crash easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This normally wouldn't matter, but we call TO_CONN on it first, which dereferences a NULL pointer.

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by teor

Keywords: easy added

The best way to fix this is to remove conn and the connection_free_.
(conn is initialised to NULL, and never used until it is freed.)

comment:2 Changed 5 years ago by teor

Resolution: fixed
Status: newclosed

The same issue exists in test_dir_handle_get_status_vote_next_consensus_signatures_busy.

But it's already fixed in master.

Note: See TracTickets for help on using tickets.