Opened 4 years ago

Closed 4 years ago

#18384 closed defect (fixed)

Silence clang-scan uninitialised warnings in ed25519_donna

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7.2-alpha
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

clang-scan turns up some warnings in the ed25519_donna code.

We might or might not want to silence these - they're initialisations of variables that clang-scan isn't smart enough to see are initialised later.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by teor

Status: newneeds_review

My branch bug18384 has these fixes, but no changes file.

comment:2 Changed 4 years ago by teor

Status: needs_reviewneeds_revision

comment:3 Changed 4 years ago by teor

Status: needs_revisionneeds_review
Version: Tor: 0.2.7.2-alpha

Added a changes file, fix on 0.2.7.2-alpha.

comment:4 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merged.

Note: See TracTickets for help on using tickets.