Opened 4 years ago

Closed 4 years ago

#18455 closed defect (fixed)

modify Tor Browser packaging to avoid language prompt

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201603R
Cc: brade, gk, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor: None

Description

We use a Tor Launcher with the language prompt feature included for hardened builds but must be careful not to included that feature in regular builds. I suspect this is causing some pain for Georg at least.

Kathy and I tried to modify Tor Launcher to skip the language prompt if there is only one choice of language, but that turns out to be difficult to do because (1) the language prompt is the first dialog opened, (2) we need to keep a modal dialog open to prevent Firefox from starting all the way, and (3) the API to enumerate the installed language packs is asynchronous (so we cannot call it until after we have a modal dialog open).

We thought of another, simpler solution: modify the gitian descriptors for the bundle step to add these two preferences to the extension-overrides.js file:

intl.locale.matchOS = false
extensions.torlauncher.prompt_for_locale = false

If other people think this is a good idea I will create a patch.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by mcs

Status: newneeds_information

comment:2 Changed 4 years ago by gk

Owner: changed from tbb-team to mcs
Status: needs_informationassigned

Sounds good to me as a defense in depth against messing up the release and the need to rebuild.

comment:3 Changed 4 years ago by mcs

Keywords: TorBrowserTeam201603R added
Sponsor: None
Status: assignedneeds_review

A patch is available for review on brade's tor-browser-bundle bug13252-03 branch:

https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug13252-03&id=fef35058f76c5605fd631ff86f65adfa9bb78be7

We tested this on Mac OS but not on Linux or Windows. It might make sense to pick this up for the #13252 Mac alpha release.

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. This is commit fef35058f76c5605fd631ff86f65adfa9bb78be7 on tor-browser-bundle master.

Note: See TracTickets for help on using tickets.