Opened 3 years ago

Closed 3 years ago

#18458 closed defect (implemented)

relax directory checking for unix sockets.

Reported by: weasel Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: must-fix-before-028-rc
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I would like to create unix two sockets, one world-writeable, the other not, in the same directory, e.g., /var/lib/tor.

Currently, tor won't let me do that.

It'd be great if I could tell it to allow this action.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by weasel

Status: newneeds_review

comment:2 Changed 3 years ago by teor

Code review:

This code looks like it works. It also simplifies some of the existing logic.

The log message that mentions "StrictDirModes" should probably say "RelaxDirModeCheck".

Thanks for the unit test. The unit tests could check that relaxing the directory mode check works. (And that no option and NoRelaxDirModeCheck do the check as they did in previous versions.)

As we are past the feature freeze date for 0.2.8, I'm tentatively placing this in 0.2.9. Please check with Nick if you think it should be in 0.2.8.

I think Yawning wrote the original code - at the very least, he understands unix sockets better than I do. I'd also like him to review it if he can.

comment:3 Changed 3 years ago by nickm

Agreed wrt the log message; tests would be nice; I'd take this in 0.2.8 since it's pretty isolated, and since debian (I hear) might need it.

comment:4 Changed 3 years ago by nickm

Keywords: must-fix-before-028-rc added

Marking these as must-fix-before-028-rc.

Actually, some of them may not need to get 'fixed' before the rc, but I believe that they should either get fixed, or we should have a good explanation of why they don't need to get fixed.

comment:5 Changed 3 years ago by dgoulet

Status: needs_reviewneeds_revision

comment:6 Changed 3 years ago by weasel

Log message updated.

comment:7 Changed 3 years ago by weasel

Status: needs_revisionneeds_review

comment:8 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

looks good; merged!

Note: See TracTickets for help on using tickets.