Opened 20 months ago

Last modified 4 months ago

#18481 new defect

Allow the fallback directory schedules to be changed outside a test network

Reported by: teor Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Trivial Keywords: tor-client fallback-directory technical-debt
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

In #4483, I made the additional schedules TestingTorNetwork. But, if it turns out they need tuning, we want to be able to change them in the default torrc in a Tor Browser release.

So they need to be turned into non-testing torrc options, and the testing values moved to the common chutney template.

This also involves carefully sanity checking any user-supplied values to these options.

Child Tickets

Change History (21)

comment:1 Changed 20 months ago by nickm

Keywords: must-fix-before-028-rc added

Marking these as must-fix-before-028-rc.

Actually, some of them may not need to get 'fixed' before the rc, but I believe that they should either get fixed, or we should have a good explanation of why they don't need to get fixed.

comment:2 Changed 19 months ago by dgoulet

Owner: changed from teor to dgoulet
Status: newaccepted

comment:3 Changed 19 months ago by teor

Thanks for taking this over, dgoulet.

The sanity checks on these options can be split into another ticket that's in 0.2.8-maint, they're not required in the rc.

comment:4 Changed 19 months ago by teor

But we need the actual options available at bootstrap time, because if #4483 isn't quite right, we need to be able to tweak the schedules in a Tor Browser point release.

This should be a search and replace to remove "Testing" from the option names, and remove the code that sets them at test time.

comment:5 Changed 19 months ago by nickm

Keywords: TorCoreTeam201603 added

comment:6 Changed 19 months ago by dgoulet

This won't affect the overall behavior of tor except changing torrc option names so we can tweak values in 028 thus we can do this one after the alpha.

comment:7 Changed 19 months ago by dgoulet

Keywords: TorCoreTeam201604 added; TorCoreTeam201603 removed
Status: acceptedneeds_review

Attempt at a fix in bug18481_028_01.

It only renames the TestingClientBootstrap options by removing the Testing in front and not requiring TestingTorNetwork to be enabled.

We still need one ticket for chutney options and another for the sanity check. This can be in 029.

comment:8 Changed 19 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

LGTM -- cherry-picking to 0.2.8. Teor, if you have the time, please make sure that this is what you had in mind? :)

comment:9 in reply to:  7 ; Changed 18 months ago by arma

Replying to dgoulet:

We still need one ticket for chutney options and another for the sanity check. This can be in 029.

dgoulet, did these tickets get made, or will they be lost now that this ticket is closed?

I ask because I ran across "TestingConsensusMaxDownloadTries" while working on #18809, and I think that one wants to lose its "Testing" prefix too.

comment:10 in reply to:  9 Changed 18 months ago by dgoulet

Replying to arma:

Replying to dgoulet:

We still need one ticket for chutney options and another for the sanity check. This can be in 029.

dgoulet, did these tickets get made, or will they be lost now that this ticket is closed?

Hrm... that one felt through the cracks! Good catch. I just created them:

#18822 and #18823

I ask because I ran across "TestingConsensusMaxDownloadTries" while working on #18809, and I think that one wants to lose its "Testing" prefix too.

Ah indeed. Did you fixed it in your #18809 branch or should we reopen this one to address that?

comment:11 Changed 17 months ago by teor

Resolution: fixed
Status: closedreopened

arma didn't fix TestingConsensusMaxDownloadTries in #18809

comment:12 Changed 17 months ago by teor

I think we should either have all schedules start with Testing, or none of them, we currently have:

  • ClientBootstrapConsensusAuthorityOnlyDownloadSchedule, but
  • TestingServerConsensusDownloadSchedule

comment:13 Changed 17 months ago by arma

I think anything that we use when TestingTorNetwork is off should not start with Testing.

comment:14 Changed 17 months ago by teor

Keywords: TorCoreTeam201606 added; must-fix-before-028-rc TorCoreTeam201604 removed
Owner: changed from dgoulet to teor
Priority: MediumVery Low
Severity: NormalTrivial
Status: reopenedassigned

I think we could just make a point release if we need to change any of the rest of these schedules. I'll check what's been patched and tidy the names up for 0.2.8-rc if I get the time. But it's really not that important.

comment:15 Changed 11 months ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.3.0.x-final

comment:16 Changed 10 months ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

Triaged out on December 2016 from 030 to 031.

comment:17 Changed 6 months ago by teor

Keywords: technical-debt added
Milestone: Tor: 0.3.1.x-finalTor: unspecified
Owner: teor deleted
Points: small0.5

We haven't ever needed to change these: this code cleanup is not important or urgent.

comment:18 Changed 5 months ago by nickm

Keywords: triage-out-030-201612 removed

comment:19 Changed 5 months ago by nickm

Keywords: TorCoreTeam201606 removed

comment:20 Changed 5 months ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:21 Changed 4 months ago by nickm

Keywords: tor-client fallback-directory added
Note: See TracTickets for help on using tickets.