Allow the fallback directory schedules to be changed outside a test network

changed milestone to %Tor: unspecified

added component::core tor/tor fallback-directory milestone::Tor: unspecified points::0.5 priority::very low severity::trivial status::new technical-debt tor-client type::defect version::tor 0.2.8.1-alpha labels

Marking these as must-fix-before-028-rc.

Actually, some of them may not need to get 'fixed' before the rc, but I believe that they should either get fixed, or we should have a good explanation of why they don't need to get fixed.

Trac:
Keywords: N/A deleted, must-fix-before-028-rc added

Trac:
Owner: teor to dgoulet
Reviewer: N/A to N/A
Status: new to accepted

Thanks for taking this over, dgoulet.

The sanity checks on these options can be split into another ticket that's in 0.2.8-maint, they're not required in the rc.

But we need the actual options available at bootstrap time, because if #4483 (moved) isn't quite right, we need to be able to tweak the schedules in a Tor Browser point release.

This should be a search and replace to remove "Testing" from the option names, and remove the code that sets them at test time.

Trac:
Keywords: N/A deleted, TorCoreTeam201603 added

This won't affect the overall behavior of tor except changing torrc option names so we can tweak values in 028 thus we can do this one after the alpha.

Attempt at a fix in bug18481_028_01.

It only renames the TestingClientBootstrap options by removing the Testing in front and not requiring TestingTorNetwork to be enabled.

We still need one ticket for chutney options and another for the sanity check. This can be in 029.

Trac:
Status: accepted to needs_review
Keywords: TorCoreTeam201603 deleted, TorCoreTeam201604 added

LGTM -- cherry-picking to 0.2.8. Teor, if you have the time, please make sure that this is what you had in mind? :)

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Replying to dgoulet:

We still need one ticket for chutney options and another for the sanity check. This can be in 029.

dgoulet, did these tickets get made, or will they be lost now that this ticket is closed?

I ask because I ran across "TestingConsensusMaxDownloadTries" while working on #18809 (moved), and I think that one wants to lose its "Testing" prefix too.

Replying to arma:

Replying to dgoulet:

We still need one ticket for chutney options and another for the sanity check. This can be in 029.

dgoulet, did these tickets get made, or will they be lost now that this ticket is closed?

Hrm... that one felt through the cracks! Good catch. I just created them:

#18822 (moved) and #18823 (moved)

I ask because I ran across "TestingConsensusMaxDownloadTries" while working on #18809 (moved), and I think that one wants to lose its "Testing" prefix too.

Ah indeed. Did you fixed it in your #18809 (moved) branch or should we reopen this one to address that?

arma didn't fix TestingConsensusMaxDownloadTries in #18809 (moved)

Trac:
Resolution: fixed to N/A
Status: closed to reopened

I think we should either have all schedules start with Testing, or none of them, we currently have:

ClientBootstrapConsensusAuthorityOnlyDownloadSchedule, but
TestingServerConsensusDownloadSchedule

I think anything that we use when TestingTorNetwork is off should not start with Testing.

I think we could just make a point release if we need to change any of the rest of these schedules. I'll check what's been patched and tidy the names up for 0.2.8-rc if I get the time. But it's really not that important.

Trac:
Owner: dgoulet to teor
Keywords: TorCoreTeam201604, must-fix-before-028-rc deleted, TorCoreTeam201606 added
Severity: Normal to Trivial
Status: reopened to assigned
Priority: Medium to Very Low

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.3.0.x-final

Triaged out on December 2016 from 030 to 031.

Trac:
Milestone: Tor: 0.3.0.x-final to Tor: 0.3.1.x-final
Keywords: N/A deleted, triage-out-030-201612 added

We haven't ever needed to change these: this code cleanup is not important or urgent.

Trac:
Keywords: N/A deleted, technical-debt added
Points: small to 0.5
Milestone: Tor: 0.3.1.x-final to Tor: unspecified
Owner: teor to N/A