#18499 closed enhancement (implemented)

Improved event selection dialog

Reported by: atagar Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Nyx Version:
Severity: Normal Keywords: log
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

To select events to log Nyx uses a weird dialog, requiring users to pick letters corresponding with the events they want. To see it press 'e' on the first page...

https://www.atagar.com/transfer/tmp/event_selection.png

This was ok years ago when tor had few events, but as you can see this now requires the user to type really arcane strings ('CaruF'?). We should change this to be similar to our config editor, showing a dialog like...

+------------------------------------------------------+
| BW event                                             |
| Bandwidth used by tor. This shows both the number of |
| bytes sent and received.                             |
+------------------------------------------------------+
| [ ] DEBUG                                            |
| [ ] INFO                                             |
| [X] NOTICE                                           |
| [X] WARN                                             |
| [X] ERR                                              |
+------------------------------------------------------+
| [ ] BW                                               |
| [ ] CIRC                                             |
| ... etc...                                           |
+------------------------------------------------------+

Note we'll be dropping the '--log' argument as part of this. A big part of the reason for this arcane alphabet soup was to allow users to specify events with that argument but this clunkiness is hardly worth it. Users can configure initial events in their nyxrc instead.

Child Tickets

Change History (6)

comment:1 Changed 18 months ago by sambuddhabasu

Presently, under "Events to log: ", when we select the events "CELL_STATS", "CIRC_BW", "CONN_BW", etc., nyx exits with an error saying, "stem.InvalidRequest: <class 'stem.response.events.CellStatsEvent'> event requires Tor version 0.2.5.2-alpha or later".

Ideally, nyx should dynamically load the EVENTS list from Tor and display it to the users. Fixing this ticket will also solve this issue.

comment:2 Changed 17 months ago by atagar

Keywords: log added

comment:3 Changed 16 months ago by sambuddhabasu

I have made the necessary changes. The updated code can be pulled from https://github.com/sammyshj/nyx/pull/6
The branch to pull from is: eventdialog

comment:4 Changed 16 months ago by sambuddhabasu

Note: I am fine with the above changes and my future contributions to be in the public domain.

comment:5 Changed 15 months ago by atagar

Thanks sambuddhabasu! Pushed your branch, along with a handful of revisions.

comment:6 Changed 14 months ago by atagar

Resolution: implemented
Status: newclosed

Oops, long overdue for this to be closed.

Note: See TracTickets for help on using tickets.