Opened 22 months ago

Last modified 14 months ago

#18502 assigned defect

Orbot tries to kill Tor processes it doesn't own

Reported by: akwizgran Owned by: n8fr8
Priority: Medium Milestone:
Component: Applications/Orbot Version:
Severity: Normal Keywords: orbot kill briar
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Orbot fails to start when Briar is running because Orbot tries and fails to kill Briar's Tor process, leading to the following error in Orbot:

Waiting for control port...
Unable to start Tor: java.lang.Exception: Cannot kill: /data/data/org.torproject.android/app_bin/tor
Set background service to FOREGROUND
TorService is shutting down
An error occurred stopping Tor: Cannot kill: /data/data/org.torproject.android/app_bin/tor
Something bad happened. Check the log

It looks like TorService#killAllDaemons() is taking its name a bit too literally. If Orbot had been running as root it would have succeeded in killing Briar's Tor process.

Child Tickets

Change History (4)

comment:1 Changed 22 months ago by n8fr8

Status: newassigned

Looking into it

comment:2 Changed 22 months ago by n8fr8

Right. Even though we start with the full path:

/data/data/org.torproject.android/app_bin/tor

at some point, we reduce it down to just "/tor" or "tor"

Will look at not doing that.

comment:3 Changed 22 months ago by n8fr8

This should help: https://github.com/n8fr8/orbot/commit/2973eaccd8987070af485e7f8b391404557534d2

Needs more testing, but hopefully we can get it into the next build.

comment:4 Changed 14 months ago by bugzilla

Killer feature :)))

Note: See TracTickets for help on using tickets.