Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#18530 closed defect (fixed)

Consider dropping support for Mac OS 10.6, 10.7, and 10.8

Reported by: mcs Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201705, tbb-7.0-must
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

Unless someone talks them out of it, Mozilla plans to drop support for Mac OS 10.6, 10.7 and 10.8 in Firefox 46, which means we will need to worry about this when we transition Tor Browser to the ESR 52 codebase. Read more here:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/gXZj0rQWEfI

We need to decide whether Tor Browser can and should continue to support those older versions of Mac OS.

Child Tickets

Attachments (1)

0001-Bug-18530-set-minSupportedOSVersion-to-10.9-on-OSX.patch (853 bytes) - added by boklm 2 years ago.

Download all attachments as: .zip

Change History (30)

comment:1 Changed 2 years ago by gk

Parent ID: #21147

comment:3 Changed 2 years ago by cypherpunks

Is there any chance that you will do not as Mozilla does?

comment:4 in reply to:  3 Changed 2 years ago by gk

Replying to cypherpunks:

Is there any chance that you will do not as Mozilla does?

We decided on Monday to follow Mozilla as it is too risky that any security fix assumes macOS > 10.9 and would break on macOS < 10.9.

This ticket is then about the transition off macOS < 10.9.

comment:5 Changed 2 years ago by gk

Keywords: TorBrowserTeam201702 added

comment:6 Changed 2 years ago by gk

Sponsor: Sponsor4

comment:7 Changed 2 years ago by cypherpunks

As the majority of users prefer to stay in the dark/silence/unawareness/etc, the most effective way to research the impact of what this ticket about is to add a warning message to the stable release of Tor Browser, e.g. something scary like "Your OS is unsupported. OK", and see the reaction of users on available communication channels.
Otherwise, their installations will be silently ruined by the automatic update to 7.0.

comment:8 in reply to:  7 Changed 2 years ago by mcs

Replying to cypherpunks:

Otherwise, their installations will be silently ruined by the automatic update to 7.0.

We have a mechanism to prevent updates on the unsupported OSes, so users' installations should not be ruined. Instead, they will see a message that points them to a website where we will provide information. We did something similar when we discontinued 32-bit support on OSX.

comment:9 Changed 2 years ago by gk

Keywords: tbb-7.0-must added

comment:10 Changed 2 years ago by gk

Keywords: TorBrowserTeam201703 added; TorBrowserTeam201702 removed

Moving tickets to March

comment:11 Changed 2 years ago by boklm

Cc: tbb-team added
Owner: changed from tbb-team to boklm
Status: newassigned

comment:12 Changed 2 years ago by gk

https://bugzilla.mozilla.org/show_bug.cgi?id=1269811 has the changes in the update infrastructure so that users don't get new updates.

I am not sure yet if we need to do something for OS X users < 10.9 that download an ESR 52 Tor Browser and want to run it.

comment:13 Changed 2 years ago by gk

Minimum target is now 10.7: https://bugzilla.mozilla.org/show_bug.cgi?id=1269790 (but still bundles won't run below 10.9)

comment:14 Changed 2 years ago by gk

If we want to be fancy we can provide a learn more link on the about dialog and the text that no further update is possible. Not sure exactly what we need to do to activate that, I just stumbled over https://bugzilla.mozilla.org/show_bug.cgi?id=1291488.

comment:15 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704 added; TorBrowserTeam201703 removed

Remmove remaining tickets over to April

comment:16 Changed 2 years ago by gk

Parent ID: #21147

Not strictly needed for getting Tor Browser based on ESR52 compiled.

comment:17 Changed 2 years ago by gk

Keywords: tbb-7.0-must-alpha added; tbb-7.0-must removed

Getting this on our radar for alpha release in less than two weeks.

comment:18 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: assignedneeds_review

I attached a patch for tools/update-responses/config.yml to add minSupportedOSVersion=10.9 on osx64. We also update the minSupportedOSVersion for osx32 (although there are probably not many osx32 users remaining, since it has been deprecated for more than 2 years).

comment:19 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704 added; TorBrowserTeam201704R removed
Status: needs_reviewneeds_information

Looks good to me. I'll update the config.yml accordingly. It seems we need (to check) two further things in this bug:

1) A proper text explaining what's going on for OS X users < 10.9. Should we link to some Mozilla article? I looked a bit at https://support.mozilla.org/t5/Install-and-Update/Firefox-support-has-ended-for-Mac-OS-X-10-6-10-7-and-10-8/ta-p/32725 but that might not be that helpful in our context.

2) Do we need to do anything to notify OS X users on < 10.9 that Tor Browser won't work? IIRC Firefox won't extract from the DMG on an unsupported system anymore. Having such a mechanism would probably be best (in addition to change the text on the website saying the min supported version is 10.9)

comment:21 in reply to:  20 Changed 2 years ago by gk

Replying to cypherpunks:

https://gitweb.torproject.org/builders/tor-browser-bundle.git/commit/?id=64f2c7dd739a2f842a5aea5ed824683efc653aa4
Not only March is gone, but 45.9esr too ;)

Thanks. This got fixed with commit 77db4e6ba0acf381d5c7184a1a245b487fd68c3c on master.

comment:22 in reply to:  19 Changed 2 years ago by gk

Replying to gk:

2) Do we need to do anything to notify OS X users on < 10.9 that Tor Browser won't work? IIRC Firefox won't extract from the DMG on an unsupported system anymore. Having such a mechanism would probably be best (in addition to change the text on the website saying the min supported version is 10.9)

The behavior of 7.0a3 is the same as the one for Firefox 53: There is a stop sign shown over the icon and if a user drags the app and tries to start it a dialog pops up that the macOS version is too old. I think we are fine in that regard.

comment:23 Changed 2 years ago by gk

The idea in comment:14 might still be a good one to have.

comment:24 in reply to:  23 ; Changed 2 years ago by mcs

Replying to gk:

The idea in comment:14 might still be a good one to have.

A little digging reveals that Mozilla sends an XML response that looks like this:

<?xml version="1.0"?>
<updates>
    <update type="minor" unsupported="true" detailsURL="https://support.mozilla.org/kb/firefox-osx" displayVersion="48.0">
</update>
</updates>

The unsupported="true" triggers the display of a special panel within the about dialog. See https://dxr.mozilla.org/mozilla-esr52/source/browser/base/content/aboutDialog-appUpdater.js#261 (or search that file for unsupported).

We would need to modify the code to look for minSupportedOSVersion instead.

comment:25 in reply to:  24 ; Changed 2 years ago by gk

Replying to mcs:

Replying to gk:

The idea in comment:14 might still be a good one to have.

A little digging reveals that Mozilla sends an XML response that looks like this:

<?xml version="1.0"?>
<updates>
    <update type="minor" unsupported="true" detailsURL="https://support.mozilla.org/kb/firefox-osx" displayVersion="48.0">
</update>
</updates>

The unsupported="true" triggers the display of a special panel within the about dialog. See https://dxr.mozilla.org/mozilla-esr52/source/browser/base/content/aboutDialog-appUpdater.js#261 (or search that file for unsupported).

We would need to modify the code to look for minSupportedOSVersion instead.

But that means it's already too late for this feature (for the alphas) and would be unless we ship a 6.5.3 with it?

Last edited 2 years ago by gk (previous) (diff)

comment:26 in reply to:  25 Changed 2 years ago by mcs

Replying to gk:

But that means it's already too late for this feature (for the alphas) and would be unless we ship a 6.5.3 with it?

Ah, you are correct. Maybe it is not worth the trouble then.

comment:27 Changed 2 years ago by gk

Keywords: TorBrowserTeam201705 added; TorBrowserTeam201704 removed

Moving our tickets to May 2017.

comment:28 in reply to:  19 Changed 2 years ago by gk

Resolution: fixed
Status: needs_informationclosed

Replying to gk:

Looks good to me. I'll update the config.yml accordingly. It seems we need (to check) two further things in this bug:

1) A proper text explaining what's going on for OS X users < 10.9. Should we link to some Mozilla article? I looked a bit at https://support.mozilla.org/t5/Install-and-Update/Firefox-support-has-ended-for-Mac-OS-X-10-6-10-7-and-10-8/ta-p/32725 but that might not be that helpful in our context.

Having that in the blog post for Tor Browser 7.0 seems enough to me.

comment:29 Changed 2 years ago by gk

Keywords: tbb-7.0-must added; tbb-7.0-must-alpha removed

We are beyond the alpha testing. Moving tickets for tbb-7.0-must.

Note: See TracTickets for help on using tickets.