Opened 4 years ago

Last modified 2 years ago

#18562 new defect

Do we need to chown AF_UNIX sockets?

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client unix-socket needs-analysis posix
Cc: Actual Points:
Parent ID: Points: medium
Reviewer: Sponsor:

Description

Weasel suspects not. When I fixed #18253, he found that if we don't allow the chown, it doesn't matter and Tor still works fine.

Of course, this needs analysis and auditing.

Child Tickets

Change History (8)

comment:1 Changed 4 years ago by weasel

We changed tor to open unix sockets after switching to the target user.

As such, when tor opens these, they should be created with the correct user already. And if they weren't, we probably wouldn't have the bits anymore to actually change that.

comment:2 Changed 4 years ago by nickm

Points: medium

comment:3 Changed 4 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:4 Changed 4 years ago by nickm

Sponsor: None

Change Core Tor tickets with sponsor "None" to "", per our practice elsewhere. This will help sorting.

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: tor-client unix-socket needs-analysis posix added
Note: See TracTickets for help on using tickets.