Opened 2 years ago

Closed 16 months ago

#18571 closed enhancement (fixed)

prop224: Encode/Decode descriptor implementation

Reported by: dgoulet Owned by: dgoulet
Priority: High Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, TorCoreTeam201609, nickm-deferred-20161005
Cc: Actual Points:
Parent ID: #17238 Points: 6
Reviewer: Sponsor: SponsorR-must

Description

This ticket is for the implementation of encoding and decoding HS descriptors. It's part of proposal 224.

Child Tickets

Change History (11)

comment:1 Changed 2 years ago by dgoulet

Owner: set to special
Status: newassigned

This branch contains a complete implementation of descriptor _encoding_ and it has some unit tests: ticket18571_029_01. I'm handing this to special for the implementation of the _decoding_.

comment:2 Changed 21 months ago by isabela

Points: large6

comment:3 Changed 20 months ago by dgoulet

The encoding work is pretty much done and thus review can start available in the following gitlab merge request. The decoding is a work in progress but needed before upstream merge.

Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/6

comment:4 in reply to:  3 Changed 20 months ago by asn

Replying to dgoulet:

The encoding work is pretty much done and thus review can start available in the following gitlab merge request. The decoding is a work in progress but needed before upstream merge.

Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/6

Hey David,

I finished a first round of review in gitlab. Nothing exciting found; mostly comments about code quality.

Will do a second round of review soon.

comment:5 Changed 20 months ago by asn

OK, David addressed my comments and added some more code.

You can find another review here:

https://gitlab.com/asn/tor/merge_requests/1/diffs#note_12822678

I did not really review the decoding commits because it said WIP and it has tons of XXX all around. So I thought of giving it some more time to mature.

I also started writing unit tests for the build_plaintext_padding() function in my ticket18571_029_04_test branch. I think the function is actually broken as it is right now. Check out the test failures.

comment:6 Changed 19 months ago by dgoulet

Keywords: TorCoreTeam201608 added

comment:7 Changed 19 months ago by dgoulet

Final product is in ticket18571_029_05.

(I'll be using the commit in that branch to build the main #17238 branch.)

comment:8 Changed 19 months ago by dgoulet

Owner: changed from special to dgoulet
Status: assignedaccepted

comment:9 Changed 18 months ago by dgoulet

Keywords: TorCoreTeam201609 added; TorCoreTeam201608 removed

Review and merge will happen in September.

comment:10 Changed 17 months ago by nickm

Keywords: nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

comment:11 Changed 16 months ago by dgoulet

Resolution: fixed
Status: acceptedclosed

Merged as part of #17238 in commits:

cff1fd63 N 2016-06-28 prop224: Descriptor decoding implementation
91b5d078 N 2016-03-08 prop224: Descriptor encoding implementation
Note: See TracTickets for help on using tickets.