Opened 5 years ago

Closed 5 years ago

#18582 closed defect (wontfix)

tor_addr_is_internal should never block PT dummy addresses

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: comment-only easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In #17674 and #8976, we block internal addresses when opening a connection.

In #18517, we chose as a dummy address range for Tor Browser to use for pluggable transports to use when they don't have the actual remote address.

Let's add a comment near the IPv4 range in tor_addr_is_internal_ to never block those addresses (or, if we do, to change how Tor Browser and PTs work first).

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by teor

Resolution: wontfix
Status: newclosed

We won't fix the issue this way, we're fixing the address check in #18517 instead.

Note: See TracTickets for help on using tickets.