Opened 4 years ago

Closed 3 years ago

#18597 closed task (fixed)

Enhance performance timing tests for esr45

Reported by: gk Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Normal Keywords: ff45-esr, TorBrowserTeam201605, tbb-6.0-must
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We currently have tests for making sure the Navigation Timing and Resource Timing APIs are disabled. We should enhance these tests to make sure

a) the getEntries methods are not working to get timing information back (done in the resource timing test)
b) the Performance Observer (https://bugzilla.mozilla.org/show_bug.cgi?id=1165796) does not provide a way to get this data
c) write a corresponding test for the User Timing API (we had #16336 for disabling the preference).

Child Tickets

TicketStatusOwnerSummaryComponent
#19039closedcypherpunksTest User Timing API in a worker contextApplications/Quality Assurance and Testing

Change History (9)

comment:1 Changed 4 years ago by gk

See: #18601 for the User Timing API being available in workers.

Last edited 3 years ago by gk (previous) (diff)

comment:2 Changed 4 years ago by boklm

c) write a corresponding test for the User Timing API (we had #16336 for disabling the preference).

I updated the resource-timing test to also check that the mark() and measure() methods from the User Timing API cannot be used:
https://gitweb.torproject.org/boklm/tor-browser-bundle-testsuite.git/commit/?id=26d22e7cde628c1bb9eb04a0f258dc31d48194b2

When setting dom.enable_user_timing to true, the test fails as expected.

comment:3 Changed 4 years ago by gk

Keywords: TorBrowserTeam201604 added

comment:4 in reply to:  2 ; Changed 4 years ago by gk

Replying to boklm:

c) write a corresponding test for the User Timing API (we had #16336 for disabling the preference).

I updated the resource-timing test to also check that the mark() and measure() methods from the User Timing API cannot be used:
https://gitweb.torproject.org/boklm/tor-browser-bundle-testsuite.git/commit/?id=26d22e7cde628c1bb9eb04a0f258dc31d48194b2

When setting dom.enable_user_timing to true, the test fails as expected.

Could we put that in an own test, test_user-timing.py for example? It seems to me having separate tests covering these separate APIs makes it both easier to understand what is going on and to test differences in those APIs.

comment:5 in reply to:  4 Changed 4 years ago by boklm

Replying to gk:

Could we put that in an own test, test_user-timing.py for example? It seems to me having separate tests covering these separate APIs makes it both easier to understand what is going on and to test differences in those APIs.

The reason for putting it in the resource-timing test was to make the testsuite run a little faster, but it does not make a big difference, so having separate tests sounds like a good idea.

I moved it to a separate test (test_user-timing.py) in commit 741c3880beedd10b044df9899f2bcacba0b81fa2.

comment:6 Changed 3 years ago by gk

Keywords: TorBrowserTeam201605 added; TorBrowserTeam201604 removed

Moving tickets

comment:7 Changed 3 years ago by boklm

Commit 492c66560e029780346b21bada0aee5f700e1bb6 adds a test to check that PerformanceObserver cannot be used:
https://gitweb.torproject.org/boklm/tor-browser-bundle-testsuite.git/commit/?id=492c66560e029780346b21bada0aee5f700e1bb6

If we enable it with dom.enable_performance_observer, the test fails as expected.

comment:8 Changed 3 years ago by gk

Keywords: tbb-6.0-must added

comment:9 Changed 3 years ago by gk

Resolution: fixed
Status: newclosed

We are done here it seems.

Note: See TracTickets for help on using tickets.