TBB/ESR45 reports "InvalidStateError" in browser console

An InvalidStateError appears in the browser console, unfortunately with no source filename or line number (only the word <unknown> for source). I tracked this error down to our setting the pref "dom.indexedDB.enabled" to false in 000-tor-browser.js. I haven't yet found where the error is being produced, but I presume it is a .jsm or .js file somewhere in the Firefox codebase, attempting to use an indexedDB.

added TorBrowserTeam201605R component::applications/tor browser ff45-esr owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-6.0-must tbb-no-uplift type::defect labels

Trac:
Keywords: N/A deleted, ff45-esr added

Trac:
Parent: #15197 (moved) to N/A

Dragging into May to have it on our 6.0 radar.

Trac:
Keywords: N/A deleted, TorBrowserTeam201605 added

Here's a patch that attempts to fix the problem.

https://github.com/arthuredelstein/tor-browser/commit/18619+1 Hash 96e76624a5e354bb059782dbe1fdeb5f8345af4e

Trac:
Keywords: TorBrowserTeam201605 deleted, TorBrowserTeam201605R added
Status: new to needs_review

Replying to arthuredelstein:

Here's a patch that attempts to fix the problem.

https://github.com/arthuredelstein/tor-browser/commit/18619+1 Hash 96e76624a5e354bb059782dbe1fdeb5f8345af4e

With this patch, an InvalidState error is no longer logged during browser startup. We still see one when we open the developer tools (Inspect Element). I don't know how difficult it would be to patch the underlying devtools/shared/async-storage.js code to avoid using IndexedDB when it has been disabled.

Replying to mcs:

Replying to arthuredelstein:

Here's a patch that attempts to fix the problem.

https://github.com/arthuredelstein/tor-browser/commit/18619+1 Hash 96e76624a5e354bb059782dbe1fdeb5f8345af4e

With this patch, an InvalidState error is no longer logged during browser startup. We still see one when we open the developer tools (Inspect Element). I don't know how difficult it would be to patch the underlying devtools/shared/async-storage.js code to avoid using IndexedDB when it has been disabled.

Thanks for the review. That's a good suggestion. I wrote an in-memory implementation that is supposed to match the indexeedDB-based version:

https://github.com/arthuredelstein/tor-browser/commit/18619+2 Hash b875e25aade0323c85915e0c09eadaf44151524f

This seems to correctly the browser console input history during a browser session. It also appears to eliminate the InvalidStateErrors both as a result of browser startup, entering things in the browser console, or using Inspect Element.

Trac:
Keywords: N/A deleted, tbb-6.0-must added

Replying to arthuredelstein:

This seems to correctly the browser console input history during a browser session. It also appears to eliminate the InvalidStateErrors both as a result of browser startup, entering things in the browser console, or using Inspect Element.

Also, I ran the test ./mach mochitest devtools/shared/tests/browser/browser_async_storage.js with "dom.indexedDB.enabled" set to false, and all the tests pass.

r=brade, r=mcs Kathy and I think your code is fine and this solution is good as well. It does mean that some developer tools state will not be persistent, but at least this way it is stored while the devtools are open (and we avoid strange errors on the console).

Applied to tor-browser-45.1.0esr-6.0-1 (commit 847b5368b573508a66c7ba38a2148fe36289fe23).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Replying to mcs:

r=brade, r=mcs Kathy and I think your code is fine and this solution is good as well. It does mean that some developer tools state will not be persistent, but at least this way it is stored while the devtools are open (and we avoid strange errors on the console). Do we really need this non-clearable by NEWNYM database? Does this patch pass https://people-mozilla.org/~spenades/test_cases/async_storage/ correctly? Mozilla closed it as a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=781982

We no longer need this patch because we stopped setting dom.indexeddb.enabled to false in #23745 (moved). So I'm marking this as tbb-no-uplift and I opened #25215 (moved) to revert the patch. We'll keep https://bugzilla.mozilla.org/show_bug.cgi?id=1432994 open in case Mozilla wants to fix the problem.

Trac:
Keywords: N/A deleted, tbb-no-uplift added

closed

mentioned in issue #18937 (moved)

mentioned in issue #21898 (moved)

mentioned in issue #25215 (moved)

moved to tpo/applications/tor-browser#18619 (closed)

mentioned in issue tpo/applications/tor-browser#25215 (closed)