HSFORGET command to clear cached client state for a HS

This is a patch used by the Android app Briar (since October 2014) that we would like to upstream. It adds an HSFORGET command to the control protocol which clears any cached client state relating to a specified hidden service. This can be used to flush state that's likely to be stale before trying to connect to a hidden service via an unstable network connection (such as a mobile data connection).

Trac:
Username: str4d

changed milestone to %Tor: unspecified

added component::core tor/tor milestone::Tor: unspecified owner::str4d points::1 priority::medium reporter::str4d reviewer::asn reviewer::special severity::normal status::needs-revision tor-control tor-hs type::enhancement v2 version::tor 0.2.7.6 labels

Trac:
Milestone: N/A to Tor: 0.2.9.x-final
Status: new to needs_review

The explicit casting of the value returned by strmap_remove_lc is unnecessary because it returns a pointer to a void which supports implicit casting.

Every postponed needs_review ticket should get a review in April

Trac:
Keywords: N/A deleted, TorCoreTeam201604 added

Thanks for this! That sounds useful and also until we have a way to reliably detect network changes in tor, I can see a use for that (well clearly you have one :).

(This also need a control-spec.txt change)

Trac:
Status: needs_review to needs_revision
Sponsor: N/A to SponsorR-can
Points: N/A to small
Keywords: TorCoreTeam201604 deleted, tor-hs added

Setting dgoulet as reviewer; please let me know if you don't want to review.

Another suggestion: if possible, it would be good to have tests for the new rendcache and rendclient functions.

Trac:
Reviewer: N/A to dgoulet

Trac:
Username: str4d

tor.patch

Patch to implement HSFORGET command in Tor 0.2.7.6

Trac:
Username: str4d

Trac:
Username: str4d

control-spec.diff

Patch to add HSFORGET command to control-spec.txt

Trac:
Username: str4d

Trac:
Status: needs_revision to needs_review

tickets market to be removed from milestone 029

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.???

Trac:
Username: str4d

tor.2.patch

Patch to implement HSFORGET command in Tor 0.2.7.6

Trac:
Username: str4d

Trac:
Username: str4d

control-spec.2.diff

Patch to add HSFORGET command to control-spec.txt

Trac:
Username: str4d

New patches uploaded that add descriptor-cookie support (as part of fixing a bug in the previous patch), as well as tests for the new rendcache and rendclient functions per comment:5.

The rendcache test currently fails, but not due to the new code - the descriptor fails to parse during test setup. I copied the descriptor from src/test/test_hs.c so it should have been fine... I am also unsure how duplicate test data should be handled in the Tor testing framework. Pointers welcome :)

Trac:
Username: str4d

Trac:
Keywords: tor-hs deleted, tor-hs 029-proposed added

These have code, so I am okay with reviewing them for this release. (no objections at today's meeting)

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.2.9.x-final
Keywords: tor-hs 029-proposed deleted, tor-hs, 029-accepted added