Opened 3 years ago

Last modified 23 months ago

#18637 accepted enhancement

Have OOM handler look at all memory consumption, not just some

Reported by: nickm Owned by: nickm
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dos oom memory-handler memory-monitoring
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor: SponsorV-can

Description

Just because our OOM handler doesn't know how to free every kind of memory we allocate, doesn't mean we shouldn't teach it to consider our total allocation when deciding that we're low on memory.

For platforms where malloc() can return NULL, we could have it look at that too.

Child Tickets

Change History (16)

comment:1 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 3 years ago by mikeperry

Keywords: tor-dos added; dos removed

Canonicalize dos tag to tor-dos

comment:3 Changed 3 years ago by isabela

Points: medium3

comment:4 Changed 3 years ago by nickm

Parent ID: #17293

comment:5 Changed 3 years ago by nickm

Owner: nickm deleted
Status: acceptedassigned

comment:6 Changed 3 years ago by nickm

Status: assignednew

Put all unowned "assigned" tickets back into "new".

comment:7 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:8 Changed 3 years ago by nickm

I started a little exploratory "how much memory are we using here" work and ran into a snag. Only on some OSs is it possible to ask "what is my RSS right now." So, this will only work there.

comment:9 Changed 3 years ago by nickm

(Is RSS what we should be looking at?)

comment:10 Changed 3 years ago by nickm

Parent ID: #17293

Leaving these in 0.2.9.x, but un-parenting . They are -can items, and their -must parent is closing.

comment:11 Changed 3 years ago by nickm

Keywords: nickm-deferred-20161005 added
Milestone: Tor: 0.2.9.x-finalTor: 0.3.0.x-final

Deferring big/risky-feature things (even the ones I really love!) to 0.3.0. Please argue if I'm wrong.

comment:12 Changed 2 years ago by dgoulet

Keywords: triage-out-030-201612 added
Milestone: Tor: 0.3.0.x-finalTor: unspecified

Triaged out on December 2016 from 030 to Unspecified.

comment:13 Changed 2 years ago by nickm

Keywords: nickm-deferred-20161005 removed

comment:14 Changed 2 years ago by nickm

Keywords: triage-out-030-201612 removed

comment:15 Changed 2 years ago by nickm

Keywords: oom memory-handler memory-monitoring added

comment:16 Changed 23 months ago by nickm

Sponsor: SponsorU-canSponsorV-can
Note: See TracTickets for help on using tickets.