OSX's man command lacks '--encoding' argument

On OSX the 'man' command lacks an '--encoding' argument which we use to normalize some of the results. As a result stem.manual.from_man and stem.manual.from_remote don't have all the fields available on other platforms.

For now a couple unit tests are disabled on OSX due to this.

added component::archived/stem owner::atagar priority::low resolution::fixed severity::normal status::closed type::defect utils labels

Trac:
Component: - Select a component to Stem
Owner: N/A to atagar

Thanks Sebastian! Pushed something that should fix this, mind giving it a whirl?

This fix really should do the trick so resolving. Feel free to reopen if it doesn't do the trick. :)

Trac:
Status: new to closed
Resolution: N/A to fixed

Unfortunately:

  File "/tor-git/stem/test/unit/manual.py", line 137, in test_parsing_with_example
    self.assertEqual('tor - The second-generation onion router', manual.name)
AssertionError: 'tor - The second-generation onion router' != ''

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Priority: Medium to Low
Description: OSX's man does not support --encoding, so an attempt to call it fails in the above tests.

to

On OSX the 'man' command lacks an '--encoding' argument which we use to normalize some of the results. As a result stem.manual.from_man and stem.manual.from_remote don't have all the fields available on other platforms.

For now a couple unit tests are disabled on OSX due to this.
Keywords: N/A deleted, utils added
Summary: test_parsing_with_example, test_parsing_with_unknown_options, test_saving_manual failures on OSX to OSX's man command lacks '--encoding' argument
Status: reopened to new

pardon me, but this isn't just an OSX issue. I use slackware-current, and --encoding=ascii doesn't work. man version = 1.6g.

What version has --encoding=ascii (or -E ascii)?

Trac:
Username: ewong

Replying to ewong:

pardon me, but this isn't just an OSX issue. I use slackware-current, and --encoding=ascii doesn't work. man version = 1.6g.

What version has --encoding=ascii (or -E ascii)?

http://www.nongnu.org/man-db/

here's my attempt at this: https://gist.github.com/ewongbb/0a53344cf53a42c28e6e790a4a321b94

Trac:
Username: ewong

Link to the branch: https://github.com/ewongbb/stem/tree/t18660

Trac:
Username: ewong

Thanks ewong! Pushed your branch with some little tweaks.

Trac:
Status: new to closed
Resolution: N/A to fixed

I think this is needed. https://github.com/ewongbb/stem/tree/t18660_2

Trac:
Username: ewong

Oops! My bad, thanks for the catch. Pushed.

nope.. my bad.. https://github.com/ewongbb/stem/tree/t18660_3 really sorry for this.

Trac:
Username: ewong

Trac:
Username: ewong
Cc: N/A to cc@pw-wspx.org

No worries in the least. Thanks again for the patches! They're much appreciated. :)

the test_from_man_when_manual_is_unavailable() test needs to also include the patch() line for HAS_ENCODING_ARG. otherwise, it'll still run and since the resulting command = 'man -P cat tor' (on bsd, mac and slackware), won't be equal to 'man --encoding=ascii -P cat tor' .. it'll fail.

https://github.com/ewongbb/stem/tree/fix_test_from_man_unavailable

this should fix it.

Trac:
Username: ewong
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Username: ewong
Status: reopened to needs_review

Thanks Edmund! Fix pushed.

Replying to Sebastian:

Unfortunately: {{{ File "/tor-git/stem/test/unit/manual.py", line 137, in test_parsing_with_example self.assertEqual('tor - The second-generation onion router', manual.name) AssertionError: 'tor - The second-generation onion router' != '' }}}

Is this still happening? I remember having this but it's now gone. (don't even remember which fixed that).

Trac:
Username: ewong

Oops! My bad, I should've resolved this. :)

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed