Opened 4 years ago

Closed 4 years ago

#18668 closed defect (fixed)

Numerous WSAStartup warnings in unit tests on windows

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-tests-coverage, tor-tests-unit, TorCoreTeam201605, review-group-2
Cc: Actual Points: 0.1
Parent ID: Points: 1
Reviewer: special Sponsor: SponsorS-can

Description

Head on over to Jenkins, and look at the windows builder output. It's complaining a lot that we aren't calling WSAStartup. We should fix that.

It's not causing bugs or preventing the tests from passing, but it sure is ugly.

Child Tickets

Change History (13)

comment:1 Changed 4 years ago by nickm

Severity: NormalMinor

comment:2 Changed 4 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:3 Changed 4 years ago by nickm

Keywords: tor-tests-coverage tor-tests-unit added

comment:4 Changed 4 years ago by nickm

Keywords: TorCoreTeam201605 added

Give myself a few items for May. I hope I can do even more than this, but let's be careful.

comment:5 Changed 4 years ago by nickm

Semi-canonical example:

https://jenkins.torproject.org/job/tor-ci-mingwcross-0.2.8-test-native/15/console
https://jenkins.torproject.org/job/tor-ci-mingwcross-master-test-native/27/console

Specifically:

13:00:48 + RESULT/bin/test
13:00:50 onion_handshake: OK
13:00:50 bad_onion_handshake: OK
13:00:50 onion_queues: OK
13:00:50 ntor_handshake: OK
13:00:50 circuit_timeout: [forking] [warn] evsig_init: socketpair: Successful WSAStartup not yet performed [WSANOTINITIALISED ]
13:00:51 OK
13:00:51 rend_fns: [forking] [warn] evsig_init: socketpair: Successful WSAStartup not yet performed [WSANOTINITIALISED ]
13:00:51 OK
 ...

comment:6 Changed 4 years ago by nickm

Status: acceptedneeds_review

Oh wait, that's pretty easy.

bug18668_028 has the fix here. I vote "no backport" but I guess we could.

comment:7 Changed 4 years ago by nickm

Actual Points: 0.1

comment:8 Changed 4 years ago by isabela

Points: small1

comment:9 Changed 4 years ago by nickm

Keywords: review-group-2 added

Create a review-group-2 from (most of the) tickets in 0.2.8 or 0.2.9 or 029-nickm-says-yes listed as needs_review,

comment:10 Changed 4 years ago by special

Reviewer: special
Status: needs_reviewmerge_ready

Makes sense. LGTM. Doesn't seem like a risk to backport this either, if you want to.

comment:11 Changed 4 years ago by nickm

taking this in 029; I don't see a point in backporting though.

comment:12 Changed 4 years ago by nickm

oh, wait, it's a regression.

comment:13 Changed 4 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to 0.2.8 and forward.

Note: See TracTickets for help on using tickets.