Opened 3 years ago

Closed 3 years ago

#18699 closed defect (fixed)

gitian-based TBB/ESR45 linux build failing on code for #10126

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, GeorgKoppen201604, TorBrowserTeam201604R
Cc: gk, boklm Actual Points:
Parent ID: #18226 Points:
Reviewer: Sponsor:

Description

Here's the error I get in gitian-builder/var/build.log:

+ for LIB in 'Browser/*.so' Browser/webapprt-stub Browser/firefox Browser/plugin-container 'Browser/components/*.so' 'Browser/browser/components/*.so' Browser/updater
+ objcopy --only-keep-debug 'Browser/components/*.so' 'Debug/Browser/components/*.so'
objcopy: 'Browser/components/*.so': No such file

This error apparently comes from tor-browser-bundle/gitian/descriptors/linux/gitian-firefox.yml:

  # Strip and generate debuginfo for the firefox binary that we keep, all *.so
  # files, the plugin-container, and the updater (see ticket #10126)
  cd $INSTDIR
  for LIB in Browser/*.so Browser/webapprt-stub Browser/firefox Browser/plugin-container Browser/components/*.so Browser/browser/components/*.so Browser/updater
  do
    objcopy --only-keep-debug $LIB Debug/$LIB
    strip $LIB
    objcopy --add-gnu-debuglink=./Debug/$LIB $LIB
  done

I haven't investigated what has changed since TBB/ESR31 yet.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by arthuredelstein

Component: - Select a componentTor Browser
Owner: set to tbb-team

comment:2 Changed 3 years ago by gk

Keywords: ff45-esr GeorgKoppen201604 TorBrowserTeam201604R added
Parent ID: #18226
Status: newneeds_review

Yes. There is no Browser/components anymore. See: bug_18699 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_18699&id=d9f2760db5479e654a8895ed58151ac9612dbbd7) in my public tor-browser-bundle repo.

comment:3 Changed 3 years ago by mcs

r=mcs, r=brade
We used to have libdbusservice.so and libmozgnome.so in components. I guess those libraries are no longer part of the package.

comment:4 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit b88da4141fa6b0b423047023939f151890e4af70.

Note: See TracTickets for help on using tickets.