Opened 4 years ago

Closed 4 years ago

#18729 closed defect (fixed)

periodic_event_dispatch too noisy at loglevel debug

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Running git master as a client, once a second I get:

Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Dispatching check_dns_honesty
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Scheduling check_dns_honesty for 1 seconds
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Dispatching record_bridge_stats
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Scheduling record_bridge_stats for 1 seconds
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Dispatching write_bridge_ns
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Scheduling write_bridge_ns for 1 seconds
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Dispatching check_ed_keys
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Scheduling check_ed_keys for 1 seconds
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Dispatching rotate_onion_key
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Scheduling rotate_onion_key for 1 seconds
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Dispatching check_fw_helper_app
Apr 05 19:11:55.838 [debug] periodic_event_dispatch(): Scheduling check_fw_helper_app for 1 seconds

This level of log bloat makes the logs unusable for much else. Is it useful or needed?

I could get behind logging these things when an event actually decided to do something worthwhile. But maybe that "doing a worthwhile thing" should include the log in that case?

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by arma

Status: newneeds_review

The patch in my bug18729 branch makes me a happy camper.

(I tried running it for a bit, and I didn't see any other crazy repeated log lines.)

comment:2 Changed 4 years ago by nickm

I think I added those logs, and I'd be happy removing them.

comment:3 Changed 4 years ago by arma

you did indeed add them, in git commit 661e5bdbfa ("based on feedback from special")

comment:4 Changed 4 years ago by arma

(should the patch just remove the lines, rather than leaving them there but commented out? I am happy either way.)

comment:5 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

I'm going to take this as-is, but cherry-pick it to 0.2.8. Remember, master is 0.2.9 now!

Note: See TracTickets for help on using tickets.