Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18737 closed defect (duplicate)

Use coverage-enabled tor-gencert when using coverage option

Reported by: cypherpunks Owned by: cypherpunks
Priority: Low Milestone:
Component: Core Tor/Tor Version: Tor: 0.2.7.3-rc
Severity: Minor Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The test-network script has support for coverage-enabled binaries with the --coverage option which was added in commit 62e6513b48009adba289243155b93da3212c00c2. This option does not enable the use of tor-cov-gencert so it always uses the non-coverage build of tor-gencert.

Child Tickets

Attachments (2)

0001-Use-coverage-enabled-tor-gencert-when-requested.patch (1.2 KB) - added by cypherpunks 3 years ago.
0002-Use-script-option-instead-of-environment-variables.patch (1.3 KB) - added by cypherpunks 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by cypherpunks

Owner: set to cypherpunks
Status: newassigned

I'm working on a patch.

comment:2 Changed 3 years ago by cypherpunks

Status: assignedneeds_review

comment:3 Changed 3 years ago by cypherpunks

Status: needs_reviewneeds_revision

Let's wait until #18240 is merged and handle the dependencies on tor-(cov-)gencert correctly with a fixup patch.

comment:4 Changed 3 years ago by cypherpunks

In #18933 isis noted that test-network.sh should also take into account $(EXEEXT).

comment:5 Changed 3 years ago by cypherpunks

Resolution: duplicate
Status: needs_revisionclosed

The work is now being done in #18933 so closing this ticket as a duplicate.

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 3 years ago by nickm

Milestone: Tor: 0.3.???

Milestone deleted

Note: See TracTickets for help on using tickets.