Opened 3 years ago

Closed 3 years ago

#18738 closed defect (fixed)

Disable Selfsupport and Unified Telemetry in ESR 45

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, GeorgKoppen201604, TorBrowserTeam201604R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

Selfsupport already landed in ESR 38 but was disabled there, I guess due to disabling the health report (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1111022 for the background). This is not the case anymore with an ESR45-based Tor Browser for some reason. We should make sure it is disabled there, too.

Child Tickets

Attachments (1)

0001-Bug-18738-Disable-Selfsupport-and-Unified-Telemetry.patch (1.2 KB) - added by gk 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by gk

Description: modified (diff)
Keywords: GeorgKoppen201604 TorBrowserTeam201604R added
Owner: changed from tbb-team to gk
Status: newassigned
Summary: Disable self-support in ESR 45Disable Selfsupport and unified Telemtry in ESR 45

In ESR45 disabling the health report is not enough anymore. At least the unified telemetry stuff needs to get disabled as well now (https://bugzilla.mozilla.org/show_bug.cgi?id=1179226).

The big plan is: https://docs.google.com/document/d/1IGpzsYGi_sq3YFQDAPyKOkU_BKvXAC95fZYA2i4ceVs/edit?pref=2&pli=1

We should do that and take the direct approach, too, setting browser.selfsupport.enabled to false.

comment:2 Changed 3 years ago by gk

Status: assignedneeds_review

Attached patch is for review.

comment:3 Changed 3 years ago by gk

Summary: Disable Selfsupport and unified Telemtry in ESR 45Disable Selfsupport and Unified Telemetry in ESR 45

comment:4 Changed 3 years ago by mcs

r=mcs
This looks good. On a related note, I wonder (as another "defense in depth" measure) if we should set datareporting.healthreport.about.reportUrlUnified to data:text/plain, like we do with its friend datareporting.healthreport.about.reportUrl.

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Good idea. Both is fixed with commit be482a800166d85c2f52d39f34c1d620abc07c87.

Note: See TracTickets for help on using tickets.