Opened 3 years ago

Closed 3 years ago

#18739 closed defect (fixed)

Do not have git ignore files that are also tracked

Reported by: cypherpunks Owned by:
Priority: Low Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Trivial Keywords: review-group-2 TorCoreTeam201505
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:


Commit eb2188168e2eca96692ec5f60f298f7bc287e990 stopped generating test scripts via Autoconf substitution but .gitignore still contains these files.

It does not interfere with git's ability to track changes in these files but it looks weird.

Child Tickets

Attachments (1)

0001-Do-not-ignore-files-that-are-being-tracked-by-git.patch (627 bytes) - added by cypherpunks 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 3 years ago by cypherpunks

Status: newneeds_review

comment:2 Changed 3 years ago by nickm

Keywords: review-group-2 added

Create a review-group-2 from (most of the) tickets in 0.2.8 or 0.2.9 or 029-nickm-says-yes listed as needs_review,

comment:3 Changed 3 years ago by nickm

Keywords: TorCoreTeam201505 added
Milestone: Tor: 0.2.???Tor: 0.2.9.x-final
Reviewer: nickm

lgtm; applying to 028 and forward

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.