"Sign in to Sync" icon not hidden in ESR45-based Tor Browser

With the patch for #16488 (moved) (rebased to the ESR45 codebase) applied, the "Sign in to Sync" text label is correctly hidden but the icon is still visible in the hamburger menu.

added TorBrowserTeam201605R component::applications/tor browser ff45-esr owner::tbb-team priority::medium resolution::fixed severity::normal status::closed type::defect labels

I previously tried upstreaming our #16488 (moved) patch to Firefox, but Chris Karlof pointed out to me that the approach is rather Tor Browser-specific: https://bugzilla.mozilla.org/show_bug.cgi?id=1217295

So here's a torbutton patch that accomplishes the same thing: https://github.com/arthuredelstein/torbutton/commit/18743 Hash 242777b8336128995219470275d50b6b6788acb1

We could then drop the tor-browser.git patch: https://github.com/arthuredelstein/tor-browser/commit/18743+1 Hash c23e50149bc76dfa0529b51f64947f556903c34f

Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201604R added

If you pay primary attention to hamburger menu, then don't forget about Synced Tabs that can be added through Customize in it. The rest is in #16778 (moved).

Moving reviews over to May 2016

Trac:
Keywords: TorBrowserTeam201604R deleted, TorBrowserTeam201605R added

Looks good to me. One nit: could you wrap that long line in torbutton_update_sync_ui()? It would make it a bit easier to read in my terminal.

Replying to gk:

Looks good to me. One nit: could you wrap that long line in torbutton_update_sync_ui()? It would make it a bit easier to read in my terminal.

Maybe also add a try/catch in that function or check that the getElementById() succeeds. That way a failure there due to future Firefox changes won't break other Torbutton features such as the circuit display.

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201605R deleted, TorBrowserTeam201605 added

Thanks for the good suggestions. Here's a new version with both things fixed.

​https://github.com/arthuredelstein/torbutton/commit/18743+1 Hash 5b17ddc4efa21716cf666594930469a99e398d44

Trac:
Keywords: TorBrowserTeam201605 deleted, TorBrowserTeam201605R added
Status: needs_revision to needs_review

Thanks. This is commit d127873b498fb83e4f608b82a8d382df25183dd3 on master.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #19511 (moved)

mentioned in issue #26058 (moved)

moved to tpo/applications/tor-browser#18743 (closed)

mentioned in issue tpo/applications/tor-browser#19511 (closed)

mentioned in issue tpo/applications/tor-browser#26058 (closed)