Make logging of rendezvous to private address quieter

In #8976 (moved), we blocked rendezvous from hidden services to private addresses.

But the warning is log_warn LD_REND, when arma wonders if it should be a protocol warning to avoid excessive logging on busy services:

  log_warn(LD_REND, "%s on circ %u", err_msg,
           (unsigned)circuit->base_.n_circ_id);

There's also a whitespace issue we might as well fix while we're there:

  if (err_msg_out) *err_msg_out = err_msg;
  else tor_free(err_msg);

changed milestone to %Tor: 0.2.8.x-final

added TorCoreTeam-postponed-201604 TorCoreTeam201605 actualpoints::very small component::core tor/tor milestone::Tor: 0.2.8.x-final must-fix-before-028-rc owner::nickm points::1 priority::medium resolution::fixed review-group-1 reviewer::asn severity::normal status::closed tor-hs type::defect version::tor 0.2.8.2-alpha labels

let's make it rate-limited.

Trac:
Status: new to accepted
Keywords: must-fix-before-028-rc tor-hs deleted, must-fix-before-028-rc tor-hs TorCoreTeam201604 added
Owner: N/A to nickm

let's make it rate-limited.

Actually let's not. PROTOCOL_WARN is fine. See branch bug18761_028. Please review? Very small patch; review should be fast if we don't start painting the bikeshed.

Trac:
Status: accepted to needs_review

Trac:
Actualpoints: N/A to very small

Calling all non-needs_information tickets for May.

Trac:
Keywords: must-fix-before-028-rc tor-hs TorCoreTeam201604 deleted, TorCoreTeam201605, TorCoreTeam201604, tor-hs, must-fix-before-028-rc added

April is over; calling these april tickets postponed into may.

Trac:
Keywords: TorCoreTeam201604 deleted, TorCoreTeam-postponed-201604 added

Trac:
Reviewer: N/A to asn

Bug:

-  log_warn(LD_REND, "%s on circ %u", err_msg,
+  log_warn(err_msg_severity, "%s on circ %u", err_msg,
            (unsigned)circuit->base_.n_circ_id);

this wants to be tor_log(err_msg_severity)

Also tor_log wants a log domain (LD_REND), so let's not lose that one either.

bug18761_028 now has a fix for that. Ready for review again.

Trac:
Keywords: N/A deleted, review-group-1 added

LGTM.

Might be worth pointing out that this patch will also suppress the following log message:

    node = node_get_by_nickname(rp_nickname, 0);
    if (!node) {
      if (err_msg_out) {
        tor_asprintf(&err_msg,
                     "Couldn't find router %s named in INTRODUCE2 cell",
                     escaped_safe_str_client(rp_nickname));
      }

      goto err;
    }

Are we OK with hiding this from HS operators? I guess yes because it's not like they can do anything about it (and it's probably caused by consensus desynchronization between client and service).

Trac:
Status: needs_review to merge_ready

Agreed. Merged. Thanks!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

Trac:
Points: small to 1

closed

changed time estimate to 8h

moved to tpo/core/tor#18761 (closed)