Opened 4 years ago

Closed 4 years ago

#18770 closed defect (fixed)

SVGs should not show in Page Info when disabled

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, TorBrowserTeam201605R
Cc: brade, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When svg.in-content.enabled = false, SVGs should not be rendered in the Media tab within Page Info.
Also see ticket:15197#comment:32 and ticket:15197#comment:33.

We should fix this in the ESR45 timeframe (although it is an issue with our ESR38-based browser too).

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by cypherpunks

Related: #18829.

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201605 added

Dragging into May to have it on our 6.0 radar.

comment:3 Changed 4 years ago by mcs

Keywords: TorBrowserTeam201605R added; TorBrowserTeam201605 removed
Status: newneeds_review

Please review the following patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug18770-01&id=cdfba424870d814b9b849c9add4a85105064f01e

We also confirmed that SVGs are blocked when used as CSS background and bullet images (a test document may be found at https://pearlcrescent.com/tor/svgtests/svgtest-css.html).

comment:4 Changed 4 years ago by gk

Cc: arthuredelstein added

Looks good to me. Arthur, could you take a look as well?

comment:5 Changed 4 years ago by arthuredelstein

Looks good to me too.

comment:6 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit 7ffe3230d2b6020394803784c140765e7c8e4b76 on tor-browser-45.1.0esr-6.0-1, thanks.

Note: See TracTickets for help on using tickets.