Opened 4 years ago

Closed 2 years ago

#18784 closed task (wontfix)

check-prerequisites.sh should check for wheezy support in vmbuilder

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

make-vms.sh fails with this configuration:

tor-browser-bundle tbb-6.0a4-build1
Ubuntu 14.04.4 LTS
python-vm-builder 0.12.4

It says "Invalid suite: 'wheezy'":

tor-browser-bundle/gitian$ ./make-vms.sh 
2016-04-10 18:34:24,430 INFO    : logging to file: /tmp/tmpGd7Ucg
2016-04-10 18:34:24,466 INFO    : Calling hook: preflight_check
2016-04-10 18:34:24,467 INFO    : Cleaning up
2016-04-10 18:34:24,467 ERROR   : Invalid suite: "wheezy". Valid suites are: dapper gutsy hardy intrepid jaunty karmic lucid maverick natty oneiric precise quantal raring saucy trusty
Traceback (most recent call last):
  File "/usr/bin/vmbuilder", line 24, in <module>
    cli.main()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/contrib/cli.py", line 221, in main
    distro.build_chroot()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/distro.py", line 81, in build_chroot
    self.call_hooks('preflight_check')
  File "/usr/lib/python2.7/dist-packages/VMBuilder/distro.py", line 67, in call_hooks
    call_hooks(self, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/util.py", line 170, in call_hooks
    getattr(context, func)(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/plugins/ubuntu/distro.py", line 102, in preflight_check
    raise VMBuilderUserError('Invalid suite: "%s". Valid suites are: %s' % (suite, ' '.join(self.suites)))
VMBuilder.exception.VMBuilderUserError: Invalid suite: "wheezy". Valid suites are: dapper gutsy hardy intrepid jaunty karmic lucid maverick natty oneiric precise quantal raring saucy trusty
cp: cannot stat ‘base-wheezy-i386’: No such file or directory
i386 wheezy VM creation failed

check-prerequsites.sh doesn't detect that vmbuilder is too old.

I don't see an option that makes vmbuilder print out its supported distros and suites. But it might be possible to grep them out of an error message:

$ vmbuilder kvm xxxx
...
VMBuilder.exception.VMBuilderUserError: No such distro. Available distros: ubuntu

Child Tickets

Change History (2)

comment:1 Changed 4 years ago by gk

Keywords: tbb-gitian added

Good idea. This could be a patch for the XXX in the script.

comment:2 Changed 2 years ago by gk

Resolution: wontfix
Status: newclosed

We are switching to rbm where those issues are no concern (anymore). We won't fix those.

Note: See TracTickets for help on using tickets.