#18799 closed defect (fixed)

disable Network Tickler

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R
Cc: brade, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #18546, Mike said:
We should patch the "Network Tickler" to be disabled for real, since it looks like it may now apply to the desktop as well.

Child Tickets

Attachments (1)

0001-Bug-18799-disable-Network-Tickler.patch (982 bytes) - added by mcs 23 months ago.
proposed fix

Download all attachments as: .zip

Change History (5)

comment:1 Changed 23 months ago by mcs

Keywords: TorBrowserTeam201604R added; TorBrowserTeam201604 removed
Status: newneeds_review

Please review the attached patch. Strictly speaking, we do not need this for the desktop Tor Browser because stubs are used everywhere except on Android. But including this patch will help Orfox and will also make it more likely that we will notice if Mozilla enables this on the desktop in the future.

comment:2 Changed 23 months ago by gk

Looks good to me if you change "is always stubbed our" -> "is always stubbed out".

Changed 23 months ago by mcs

proposed fix

comment:3 in reply to:  2 Changed 23 months ago by mcs

Replying to gk:

Looks good to me if you change "is always stubbed our" -> "is always stubbed out".

Oops. Fixed.

comment:4 Changed 22 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is commit 5930bd9baf2993808214781075e95c89b6ad2f20 on tor-browser-45.0.2esr-6.x-1.

Note: See TracTickets for help on using tickets.