Remove localhost DNS lookup in nsProfileLock.cpp

In #18546 (moved), Mike said: We should get rid of the damn DNS lookup for localhost in toolkit/profile/nsProfileLock.cpp.

added TorBrowserTeam201604R component::applications/tor browser ff45-esr owner::mcs priority::medium resolution::fixed severity::normal status::closed tbb-6.0a5 tbb-proxy-bypass type::defect labels

Kathy and I are not sure what the best fix is for this issue. A symlink lock is used on Mac OS and Linux if fnctl-based locking fails. The symlink is named .parentlock and points to a "signature" string that looks like: ipaddr:pid, e.g., .parentlock -> 192.168.1.99:54301 One approach would be to always use 127.0.0.1 for the IP address. Other ideas? I guess with modern NFS we will never get here because fcntl() is supported by the (network) file system? Kathy and I are not 100% sure about that though.

Trac:
Cc: brade, gk to brade, gk, mikeperry
Status: new to needs_information

A patch that uses the 127.0.0.1 solution is available here: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug18800-01&id=b6f1dac7b1e7b2bbe3ccf673f4f0f46df67b7a07

Please review.

Trac:
Status: needs_information to needs_review
Keywords: TorBrowserTeam201604 deleted, TorBrowserTeam201604R added

Let's try that one. Just one nit "as the same time" -> "at the same time".

Replying to gk:

Let's try that one. Just one nit "as the same time" -> "at the same time".

Fixed. Please use this one: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug18800-02&id=1afada0068a11265f291b8c836854391f532e754

Applied as commit 1afada0068a11265f291b8c836854391f532e754 on tor-browser-45.0.2esr-6.x-1.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

No words. #17949 (moved)

Trac:
Keywords: N/A deleted, tbb-proxy-bypass added

closed

moved to tpo/applications/tor-browser#18800 (closed)