Opened 3 years ago

Closed 3 years ago

Last modified 8 months ago

#18800 closed defect (fixed)

Remove localhost DNS lookup in nsProfileLock.cpp

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R, tbb-proxy-bypass
Cc: brade, gk, mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #18546, Mike said:
We should get rid of the damn DNS lookup for localhost in toolkit/profile/nsProfileLock.cpp.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by mcs

Cc: mikeperry added
Status: newneeds_information

Kathy and I are not sure what the best fix is for this issue. A symlink lock is used on Mac OS and Linux if fnctl-based locking fails. The symlink is named .parentlock and points to a "signature" string that looks like: ipaddr:pid, e.g.,

.parentlock -> 192.168.1.99:54301

One approach would be to always use 127.0.0.1 for the IP address. Other ideas? I guess with modern NFS we will never get here because fcntl() is supported by the (network) file system? Kathy and I are not 100% sure about that though.

comment:2 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201604R added; TorBrowserTeam201604 removed
Status: needs_informationneeds_review

comment:3 Changed 3 years ago by gk

Let's try that one. Just one nit "as the same time" -> "at the same time".

comment:4 in reply to:  3 Changed 3 years ago by mcs

Replying to gk:

Let's try that one. Just one nit "as the same time" -> "at the same time".

Fixed. Please use this one:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug18800-02&id=1afada0068a11265f291b8c836854391f532e754

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied as commit 1afada0068a11265f291b8c836854391f532e754 on tor-browser-45.0.2esr-6.x-1.

comment:6 Changed 3 years ago by bugzilla

No words. #17949

comment:7 Changed 8 months ago by tom

Keywords: tbb-proxy-bypass added
Note: See TracTickets for help on using tickets.