disable the dom.push prefs

In #18546 (moved), Mike said: We should disable all of the dom.push.* prefs. Even though it seems that only ServiceWorkers can use Push, it would be good for us to ensure now that if we decide to enable ServiceWorkers, push stays off.

added TorBrowserTeam201604R component::applications/tor browser ff45-esr owner::mcs priority::medium resolution::fixed severity::normal status::closed tbb-6.0a5 type::defect labels

Trac:
0001-Bug-18801-disable-the-dom.push-prefs.patch

proposed fix

Please review the attached patch.

Trac:
Keywords: TorBrowserTeam201604 deleted, TorBrowserTeam201604R added
Status: new to needs_review

It seems Mozilla did already a good job at disabling the DOM Push prefs. See: https://mxr.mozilla.org/mozilla-esr45/source/modules/libpref/init/all.js. So, the only thing that is actually missing is getting rid of the serverURL?

Trac:
0001-Bug-18801-clear-the-DOM-Push-server-URL.patch

revised patch

Replying to gk:

It seems Mozilla did already a good job at disabling the DOM Push prefs. See: https://mxr.mozilla.org/mozilla-esr45/source/modules/libpref/init/all.js. So, the only thing that is actually missing is getting rid of the serverURL?

Yes, you are correct. Sorry about that. Please use the revised patch that I just attached to this ticket.

Looks good to me.

This is 9ae06f7daf5a83639ac0b3532cf29c42626086f4 on tor-browser-45.0.2esr-6.x-1.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#18801 (closed)