Opened 3 years ago

Closed 3 years ago

#18801 closed defect (fixed)

disable the dom.push prefs

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R
Cc: brade, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #18546, Mike said:
We should disable all of the dom.push.* prefs. Even though it seems that only ServiceWorkers can use Push, it would be good for us to ensure now that if we decide to enable ServiceWorkers, push stays off.

Child Tickets

Attachments (2)

0001-Bug-18801-disable-the-dom.push-prefs.patch (1.1 KB) - added by mcs 3 years ago.
proposed fix
0001-Bug-18801-clear-the-DOM-Push-server-URL.patch (1.2 KB) - added by mcs 3 years ago.
revised patch

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by mcs

proposed fix

comment:1 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201604R added; TorBrowserTeam201604 removed
Status: newneeds_review

Please review the attached patch.

comment:2 Changed 3 years ago by gk

It seems Mozilla did already a good job at disabling the DOM Push prefs. See: https://mxr.mozilla.org/mozilla-esr45/source/modules/libpref/init/all.js. So, the only thing that is actually missing is getting rid of the serverURL?

Changed 3 years ago by mcs

revised patch

comment:3 in reply to:  2 Changed 3 years ago by mcs

Replying to gk:

It seems Mozilla did already a good job at disabling the DOM Push prefs. See: https://mxr.mozilla.org/mozilla-esr45/source/modules/libpref/init/all.js. So, the only thing that is actually missing is getting rid of the serverURL?

Yes, you are correct. Sorry about that. Please use the revised patch that I just attached to this ticket.

comment:4 Changed 3 years ago by gk

Looks good to me.

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is 9ae06f7daf5a83639ac0b3532cf29c42626086f4 on tor-browser-45.0.2esr-6.x-1.

Note: See TracTickets for help on using tickets.