Opened 3 years ago

Closed 3 years ago

Last modified 9 months ago

#18821 closed task (fixed)

Make sure libmdns is Android only and disabled for Orfox

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Critical Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R GeorgKoppen201604, tbb-proxy-bypass
Cc: brade, mcs, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

This is a spin-off of #18546. We should make sure that /netwerk/dns/mdns/libmdns is no risk for Tor Browser/Orfox.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by gk

Owner: changed from tbb-team to gk
Status: newassigned

comment:2 Changed 3 years ago by gk

Description: modified (diff)

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201604R added; TorBrowserTeam201604 removed
Status: assignedneeds_review

libmdns is not Android only. https://bugzilla.mozilla.org/show_bug.cgi?id=1225726 makes it available for OS X as well. However, due to stability issues it got disabled by https://bugzilla.mozilla.org/show_bug.cgi?id=1217807. That one in turn does not seem to affect Orfox, though. Thus, we have a non-preference approach backing basically the patches out that enabled mDNS on OSX and Android.
bug_18221_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_18821_v2) has it up for review.

Last edited 3 years ago by gk (previous) (diff)

comment:4 Changed 3 years ago by mcs

Cc: brade mcs arthuredelstein added

Do we also want to back out the netwerk/dns/mdns/libmdns/nsMulticastDNSModule.cpp changes that were made by https://hg.mozilla.org/mozilla-central/rev/6bfb430de85d ? It is not clear to me how all of these pieces fit together....

comment:5 Changed 3 years ago by gk

Yes, this is quite some amount of code and complexity. Good catch, although I am less worried about OS X as the preference (dom.presentation.discovery.enabled seems to get obeyed). I've fixed this in bug_18821_v3 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_18821_v3).

comment:6 in reply to:  5 Changed 3 years ago by mcs

Replying to gk:

Yes, this is quite some amount of code and complexity. Good catch, although I am less worried about OS X as the preference (dom.presentation.discovery.enabled seems to get obeyed). I've fixed this in bug_18821_v3 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_18821_v3).

This looks good except somehow you lost the word "false" in your commit message after the phrase "which is actually set to".

comment:7 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Oops. Fixed in commit 7ce38290aaac3b6351061f9ecc5cd6751d10edb4 on tor-browser-45.0.2esr-6.x-1.

comment:8 Changed 9 months ago by tom

Keywords: tbb-proxy-bypass added
Note: See TracTickets for help on using tickets.