Opened 4 years ago

Closed 3 years ago

#18831 closed enhancement (fixed)

We need Yasm >= 1.2.0 to build ESR 52

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-gitian, TorBrowserTeam201704R, GeorgKoppen201703, tbb-7.0-must-nightly
Cc: Actual Points:
Parent ID: #21240 Points:
Reviewer: Sponsor: Sponsor4

Description

It might not be available as a configure check then (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1260362) but we need Yasm >= 1.2.0 for ESR 52 due to https://bugzilla.mozilla.org/show_bug.cgi?id=1214462.

Child Tickets

Change History (14)

comment:1 Changed 3 years ago by gk

Parent ID: #21147

comment:2 Changed 3 years ago by gk

Sponsor: Sponsor4

comment:3 Changed 3 years ago by gk

Keywords: tbb-7.0-must added

comment:4 Changed 3 years ago by gk

Keywords: TorBrowserTeam201703 added

Getting those tickets on our March radar as well.

comment:5 Changed 3 years ago by gk

Keywords: GeorgKoppen201703 added

Adding to my plate.

comment:6 Changed 3 years ago by gk

Keywords: tbb-7.0-must-nightly added

We want those tickets for our first ESR52 nightlies.

comment:7 Changed 3 years ago by gk

Keywords: GeorgKoppen201703R added; GeorgKoppen201703 removed
Status: newneeds_review

comment:8 Changed 3 years ago by cypherpunks

comment:9 in reply to:  8 Changed 3 years ago by gk

Replying to cypherpunks:

Ubuntu 12.04 LTS (Precise Pangolin) will be EOLed in less than a month https://lists.ubuntu.com/archives/ubuntu-security-announce/2017-March/003777.html.

Yes, we have #18691 for that issue (although we might want to switch to Jessie while we are at it). For now it is faster just to add Yasm 1.2.0 support, though, I think. We need to get nightly builds going ASAP. I am fine if we try switching away from 12.04 later in the alpha cycle.

Also why not https://bugzilla.mozilla.org/show_bug.cgi?id=1113450?

Because the idea was to keep the version diff as small as possible to avoid possible issues with a version that is "too new".

Last edited 3 years ago by gk (previous) (diff)

comment:10 Changed 3 years ago by gk

Parent ID: #21147#21240

comment:11 Changed 3 years ago by gk

Keywords: TorBrowserTeam201704R GeorgKoppen201703 added; TorBrowserTeam201703 GeorgKoppen201703R removed

comment:12 Changed 3 years ago by gk

Keywords: tbb-7.0-must removed

No need to use somewhat duplicated keywords.

comment:13 in reply to:  7 Changed 3 years ago by boklm

Replying to gk:

bug_18831_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_18831_v3&id=6a2363caf530f0cdb11e879010c553c390e711b9) in my public tor-browser-bundle repo has a fix up for review.

This patch looks good to me.

comment:14 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is commit 910094fc33ae4e75e10fee754bec106e83e0eac5 on tor-browser-bundle master.

Note: See TracTickets for help on using tickets.