We need Yasm >= 1.2.0 to build ESR 52

It might not be available as a configure check then (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1260362) but we need Yasm >= 1.2.0 for ESR 52 due to https://bugzilla.mozilla.org/show_bug.cgi?id=1214462.

added GeorgKoppen201703 TorBrowserTeam201704R component::applications/tor browser ff52-esr owner::tbb-team parent::21240 priority::medium resolution::fixed severity::normal sponsor::4 status::closed tbb-7.0-must-nightly tbb-gitian type::enhancement labels

Trac:
Parent: N/A to #21147 (moved)

Trac:
Sponsor: N/A to Sponsor4

Trac:
Keywords: N/A deleted, tbb-7.0-must added

Getting those tickets on our March radar as well.

Trac:
Keywords: N/A deleted, TorBrowserTeam201703 added

Adding to my plate.

Trac:
Keywords: N/A deleted, GeorgKoppen201703 added

We want those tickets for our first ESR52 nightlies.

Trac:
Keywords: N/A deleted, tbb-7.0-must-nightly added

bug_18831_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_18831_v3&id=6a2363caf530f0cdb11e879010c553c390e711b9) in my public tor-browser-bundle repo has a fix up for review.

Trac:
Status: new to needs_review
Keywords: GeorgKoppen201703 deleted, GeorgKoppen201703R added

Ubuntu 12.04 LTS (Precise Pangolin) will be EOLed in less than a month https://lists.ubuntu.com/archives/ubuntu-security-announce/2017-March/003777.html. Also why not https://bugzilla.mozilla.org/show_bug.cgi?id=1113450?

Replying to cypherpunks:

Ubuntu 12.04 LTS (Precise Pangolin) will be EOLed in less than a month https://lists.ubuntu.com/archives/ubuntu-security-announce/2017-March/003777.html.

Yes, we have #18691 (moved) for that issue (although we might want to switch to Jessie while we are at it). For now it is faster just to add Yasm 1.2.0 support, though, I think. We need to get nightly builds going ASAP. I am fine if we try switching away from 12.04 later in the alpha cycle.

Also why not https://bugzilla.mozilla.org/show_bug.cgi?id=1113450?

Because the idea was to keep the version diff as small as possible to avoid possible issues with a version that is "too new".

Trac:
Parent: #21147 (moved) to #21240 (moved)

Trac:
Keywords: TorBrowserTeam201703, GeorgKoppen201703R deleted, TorBrowserTeam201704R, GeorgKoppen201703 added

No need to use somewhat duplicated keywords.

Trac:
Keywords: tbb-7.0-must deleted, N/A added

Replying to gk:

bug_18831_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_18831_v3&id=6a2363caf530f0cdb11e879010c553c390e711b9) in my public tor-browser-bundle repo has a fix up for review.

This patch looks good to me.

This is commit 910094fc33ae4e75e10fee754bec106e83e0eac5 on tor-browser-bundle master.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #21240 (moved)

mentioned in issue #30736 (moved)

moved to tpo/applications/tor-browser#18831 (closed)

mentioned in issue tpo/applications/tor-browser#30736 (closed)