Opened 4 years ago

Closed 4 years ago

#18832 closed defect (fixed)

Support parsing Torperf results files written by OnionPerf

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: iwakeh Actual Points:
Parent ID: #18746 Points:
Reviewer: Sponsor:


I'm testing OnionPerf which is supposed to become the new Torperf and which also produces .tpf files. When parsing those files with metrics-lib, I noticed a few problems and wrote patches for those. I'll post a branch shortly (once I have a ticket number).

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by karsten

Cc: iwakeh added
Status: newneeds_review

comment:2 Changed 4 years ago by iwakeh

Is there a guarantee that Integer.parseInt(percentileString); will always succeed?
Otherwise, it might be better to catch the possible exception(s) and throw DescriptorParseException in the catch clause?

comment:3 Changed 4 years ago by karsten

Oh, good catch, there is of course no such guarantee! But I think that we need to treat those keys differently than throwing an exception. It's allowed to add new keys, and some of those yet unknown keys might have DATEPERC as prefix. Yes, I know, far fetched, but it's easy to treat those keys as unknown in that case. I just added a fix and a test. Want to look again? Thanks!

comment:4 Changed 4 years ago by iwakeh

Status: needs_reviewmerge_ready

All fine! I think.

comment:5 Changed 4 years ago by iwakeh

Parent ID: #18746

comment:6 Changed 4 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks! Squashed the last two commits and merged to master. Closing.

Note: See TracTickets for help on using tickets.