Make zip and tar helpers generate reproducible archives without relying on libfaketime

In the Tor Browser build process, we are using some helper scripts to generate zip and tar archives reproducibly. Those helper scripts expect the modification time of the included files to be reproducible, which is the case when we are using libfaketime during the builds.

To be able to remove the use of libfaketime in some parts of the build process and still generate reproducible archives, we could update the helper scripts to change the time of all files included in the archives according to $REFERENCE_DATETIME.

added TorBrowserTeam201605R component::applications/tor browser owner::boklm priority::medium resolution::fixed severity::normal status::closed tbb-gitian type::enhancement labels

Moving tickets

Trac:
Keywords: TorBrowserTeam201604 deleted, TorBrowserTeam201605 added

Trac:
0001-Bug-18845-generate-reproducible-archives-without-rel.patch

I attached a patch to do that. I tried a build of tbb-6.0a5-build4 with this patch, and it did not modify the result of the build.

Trac:
Keywords: TorBrowserTeam201605 deleted, TorBrowserTeam201605R added
Status: new to needs_review

I think we should rip out the faktetime parts we don't need anymore due to these changes and then retest in order to make sure we did not overlook something. E.g. in gitian-utils.yml for Linux the faketime part for the zipping can go and in gitian-tor.yml + the PT descriptor for Linux all libfaketime related instructions can get ripped out. I guess the preloading libfaketime after the packaging step in gitian-firefox.yml can go now as well (the remaining bits would be part of #18291 (moved)). Could be interesting to see whether the libfaketime usage can get ripped out of the bundle step, too.

Trac:
Keywords: TorBrowserTeam201605R deleted, TorBrowserTeam201605 added
Status: needs_review to needs_revision

Trac:
0001-Bug-18845-generate-reproducible-archives-without-rel-v2.patch

I attached a new version of the patch doing the same thing in build-helpers/ddmg.sh.

I will also post some patches in #18291 (moved) soon. So far I have been able to completely rip out faketime from linux and osx builds, but not yet for the Windows builds where I get some differences in tor.exe and some pluggable transports files (the firefox part seems to be fine).

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201605 deleted, TorBrowserTeam201605R added

Fixed with commit 0a88a5c3919bb10e0567ddd0e6a7a4b192d3cf18 on master, thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #20258 (moved)

moved to tpo/applications/tor-browser#18845 (closed)

mentioned in issue tpo/applications/tor-browser#20258 (closed)