Opened 4 years ago

Closed 4 years ago

#18848 closed defect (fixed)

Additional welcome URL is shown in ESR 45 based Tor Browser

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Testing a build with tor-browser-45.0.2esr-6.x-1 resulted in startup.homepage_welcome_url.additional's value being loaded on first start for some reason. Maybe we have forgotten to bump a pref here? Skimming our pref file did not show something obvious here, though.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by gk

This is due to

additionalPage = Services.urlFormatter.formatURLPref("startup.homepage_welcome_url.additional");

and

    if (additionalPage && additionalPage != "about:blank") {
      if (overridePage) {
        overridePage += "|" + additionalPage;
      } else {
        overridePage = additionalPage;
      }
    }

In Tor Browser based on ESR38 overridePage is an empty string.

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201604R added; TorBrowserTeam201604 removed
Status: newneeds_review

bug_18848 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_18848) has a fix for review (disabling the Windows 10 first start URL as well)

comment:3 in reply to:  2 Changed 4 years ago by mcs

Replying to gk:

bug_18848 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_18848) has a fix for review (disabling the Windows 10 first start URL as well)

r=brade, r=mcs
Looks good.

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit 5d9a6f8007e36a0276f3333fd5bcad2ffe69a2f7 on tor-browser-45.0.2esr-6.x-1.

Note: See TracTickets for help on using tickets.