Opened 4 years ago

Closed 3 years ago

#18849 closed defect (fixed)

Fix router_picked_poor_directory_log() before 0.2.8 release

Reported by: teor Owned by: andrea
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: must-fix-before-028-rc-deferred
Cc: Actual Points: 0.1
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

Users and developers still report log messages like this:
router_picked_poor_directory_log(): Bug: Firewall denied all OR and Dir addresses for all relays when searching for a directory. (on Tor 0.2.8.1-alpha-dev 9093e3769746742f)

After #18616 is fixed, we need to work out whether these logs still occur, and whether they are genuine bugs that affect reachability, or spurious warnings that should be eliminated.

Child Tickets

Change History (12)

comment:1 Changed 4 years ago by nickm

Keywords: TorCoreTeam201605 added

comment:2 Changed 4 years ago by nickm

Keywords: must-fix-before-028-rc TorCoreTeam201605must-fix-before-028-rc, TorCoreTeam201605

Calling all non-needs_information tickets for May.

comment:3 Changed 4 years ago by andrea

Owner: set to andrea
Status: newassigned

comment:4 Changed 3 years ago by teor

Keywords: must-fix-before-028-rc-deferred added; must-fix-before-028-rc TorCoreTeam201605 removed
Points: 0.5
Resolution: fixed
Status: assignedclosed

We think this is fixed in 0.2.8.3-alpha by fixing other bugs. If not, let's reopen this ticket.

comment:5 Changed 3 years ago by teor

I'd like to reword the log entries so they explain that it's not necessarily a bug, particularly if the network is down.

comment:6 Changed 3 years ago by teor

Resolution: fixed
Status: closedreopened

comment:7 Changed 3 years ago by s7r

A relay which has been running fine for quite some time, the network is not down, I have hundreds of these messages in the log files and tor service is still running, but logging only similar warnings. This occurs on Tor version 0.2.8.1-alpha-dev (git-58bcae37a2c63db8+26ab2e0).

Jun 22 04:15:36.000 [warn] router_picked_poor_directory_log(): Bug: Firewall denied all OR and Dir addresses for all relays when searching for a directory. (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug: Node search initiated by. Stack trace: (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(log_backtrace+0x42) [0x7f7c061a7642] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(+0x86206) [0x7f7c060f5206] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(+0x864cd) [0x7f7c060f54cd] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(directory_get_from_dirserver+0x3ed) [0x7f7c0617777d] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(+0x85a28) [0x7f7c060f4a28] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(launch_descriptor_downloads+0x277) [0x7f7c060fc7a7] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(update_consensus_router_descriptor_downloads+0x26b) [0x7f7c060fdefb] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(update_all_descriptor_downloads+0x50) [0x7f7c060fe4c0] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(directory_info_has_arrived+0x1b0) [0x7f7c060b1b40] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(+0x10d8b9) [0x7f7c0617c8b9] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(connection_dir_reached_eof+0x29) [0x7f7c0617d319] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(connection_handle_read+0x8c5) [0x7f7c06158555] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(+0x42711) [0x7f7c060b1711] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x414) [0x7f7c0577d254] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(do_main_loop+0x225) [0x7f7c060b2335] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(tor_main+0x1c9d) [0x7f7c060b5a2d] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(main+0x19) [0x7f7c060ae029] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfd) [0x7f7c04999ead] (on Tor 0.2.8.1-alpha-dev )
Jun 22 04:15:36.000 [warn] Bug:     /usr/bin/tor(+0x3f079) [0x7f7c060ae079] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] router_picked_poor_directory_log(): Bug: Firewall denied all OR and Dir addresses for all relays when searching for a directory. (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug: Node search initiated by. Stack trace: (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(log_backtrace+0x42) [0x7f7c061a7642] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(+0x86206) [0x7f7c060f5206] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(+0x864cd) [0x7f7c060f54cd] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(directory_get_from_dirserver+0x3ed) [0x7f7c0617777d] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(+0x85a28) [0x7f7c060f4a28] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(launch_descriptor_downloads+0x277) [0x7f7c060fc7a7] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(update_consensus_router_descriptor_downloads+0x26b) [0x7f7c060fdefb] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(update_all_descriptor_downloads+0x50) [0x7f7c060fe4c0] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(+0x3f7a3) [0x7f7c060ae7a3] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(+0x595f6) [0x7f7c060c85f6] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x414) [0x7f7c0577d254] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(do_main_loop+0x225) [0x7f7c060b2335] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(tor_main+0x1c9d) [0x7f7c060b5a2d] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(main+0x19) [0x7f7c060ae029] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfd) [0x7f7c04999ead] (on Tor 0.2.8.1-alpha-dev )
Jun 22 06:22:35.000 [warn] Bug:     /usr/bin/tor(+0x3f079) [0x7f7c060ae079] (on Tor 0.2.8.1-alpha-dev )

comment:8 Changed 3 years ago by teor

We think this is fixed in 0.2.8.3-alpha by fixing other bugs.
Would you mind running 0.2.8.4-rc to check?

comment:9 Changed 3 years ago by s7r

Not at all. Thought more info would result from the full trace. Will try now with 0.2.8.4-rc

comment:10 Changed 3 years ago by arma

This bug seems to be happening, a lot, on moria1, running git master.

I had been thinking maybe it is because directory authorities make different assumptions about reachability than normal relays?

But if s7r sees it on a normal relay, maybe it is something else.

comment:11 Changed 3 years ago by teor

Actual Points: 0.1
Status: reopenedneeds_review

Please see my branch bug18849 on https://github.com/teor2345/tor.git

It makes both warnings LD_DIR rather than LD_BUG, demotes the "no relay" log to debug level, makes that message more explanatory, and removes the stack trace (it only alarmed people).

comment:12 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged!

Note: See TracTickets for help on using tickets.