Opened 3 years ago

Last modified 17 months ago

#18852 new defect

Directory mirrors should check accounting usage more frequently

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: tor-relay, directory, mirror, accounting, usage, bandwidth, tor-dos
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description (last modified by nickm)

After merging #12538 and #18616, Tor can wait up to 18 hours before checking whether the accounting usage has increase so much that we want to stop advertising DirPort and begindir support.

This is not great for relays with daily accounting periods.

I suggest we check every hour to see whether the result of router_should_be_directory_server() has changed. If so, we should mark_my_descriptor_dirty() with an appropriate message about deciding to advertise or stop advertising directory service support / DirPort.

This likely also means separating the calculation part of router_should_be_directory_server() from the logging, otherwise we will log duplicate messages each time we change our minds about our accounting.

Child Tickets

Change History (13)

comment:1 Changed 3 years ago by teor

Keywords: must-fix-before-028-rc added

comment:2 Changed 3 years ago by nickm

Description: modified (diff)

comment:3 Changed 3 years ago by teor

Keywords: 029-proposed added; must-fix-before-028-rc removed
Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

Relays close to their bandwidth limits won't turn off directory support for up to 18 hours. This is an existing issue, we're just making more relays serve directory documents in #12538.

So I'm proposing that this get fixed in 0.2.9.

comment:4 Changed 3 years ago by nickm

Points: small

comment:5 Changed 3 years ago by nickm

Keywords: 029-nickm-says-no added

Marking these tickets as ones I propose we do not include in 029.

comment:6 Changed 3 years ago by nickm

Keywords: 029-proposed 029-nickm-says-no removed

Nobody objected to these, so they aren't going into 029 milestone. Please re-add 029-proposed if you disagree, and let me know why.

comment:7 Changed 3 years ago by nickm

Parent ID: #18616

comment:8 Changed 3 years ago by arma

I'm removing the parent so #18616 can get closed when it's ready.

comment:9 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:10 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:11 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:12 Changed 2 years ago by nickm

Keywords: tor-relay directory mirror accounting usage dos bandwidth added

comment:13 Changed 17 months ago by dgoulet

Keywords: tor-dos added; dos removed

Rename keyword "dos" to "tor-dos"

Note: See TracTickets for help on using tickets.