Opened 3 years ago

Closed 3 years ago

#18855 closed defect (fixed)

Add-on directory clean-up error after update check

Reported by: gk Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, TorBrowserTeam201605R, tbb-6.0-must
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It seems we get an error after the add-on update check with ESR45:

1461145678000	addons.xpi	ERROR	Failed to clean updated system add-ons directories.: Unix error 2 during operation DirectoryIterator.prototype.next on file /path/to/tor-browser/Browser/TorBrowser/Data/Browser/profile.default/features (file or directory not found) ((unknown module)) No traceback available

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201605 added

Dragging into May to have it on our 6.0 radar.

comment:2 Changed 3 years ago by mcs

Cc: brade mcs added

After some debugging, Kathy and I found that this occurs because the code tries to iterate over the contents of a directory that does not exist. An existence check was added for Firefox 47. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1246614

Should we backport the fix? It is trivial:
https://hg.mozilla.org/mozilla-central/rev/49cd9160c34b

comment:3 Changed 3 years ago by gk

Yes, that would lead to less confusion and should not cause any new issues.

comment:4 Changed 3 years ago by mcs

Owner: changed from tbb-team to mcs
Status: newassigned

comment:5 Changed 3 years ago by gk

Keywords: tbb-6.0-must added

comment:6 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201605R added; TorBrowserTeam201605 removed
Status: assignedneeds_review

comment:7 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to tor-browser-45.1.0esr-6.0-1 (commit ecf19e655e6f6b94c311f3c69e56fea31bdb4185), thanks.

Note: See TracTickets for help on using tickets.