Opened 3 years ago

Closed 3 years ago

#18863 closed defect (fixed)

Disable MozTCPSocket for sure

Reported by: gk Owned by:
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

dom.mozTCPSocket.enabled is not really exposed in about:config (at least on desktop not). We should just set it to false to avoid any uncertainty about it.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201604R added; TorBrowserTeam201604 removed
Status: newneeds_review

comment:2 Changed 3 years ago by gk

Component: - Select a componentApplications/Tor Browser

comment:3 in reply to:  1 Changed 3 years ago by mcs

Replying to gk:

bug_18863 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_18863) has the patch, please review.

r=mcs
(although I wish the implementation was not in Tor Browser at all)

comment:4 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Commit c659c00756a77d0ca923aa21ca4e429deec3b3c5 on tor-browser-45.0.2esr-6.x-1 has the fix. Yes, we could rip that part fully out which is #18866.

Note: See TracTickets for help on using tickets.