Changes between Initial Version and Version 1 of Ticket #18873, comment 3


Ignore:
Timestamp:
Oct 28, 2016, 8:17:20 PM (3 years ago)
Author:
chelseakomlo
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18873, comment 3

    initial v1  
    1919A few things that I did not do:
    2020- I did not add unit tests for needs_hs_client_circuits, as it would require mocking the behavior of rep_hist_get_predicted_internal. I could definitely do that as part of this patch though.
    21 - I did not deeply analyze the logic in needs_exit_circuits, needs_hs_server_circuits, needs_hs_client_circuits, or needs_circuits_for_build_time as I'm still a bit unfamiliar with the domain.
     21- I did not deeply analyze the logic in needs_exit_circuits, needs_hs_server_circuits, needs_hs_client_circuits, or needs_circuits_for_build as I'm still a bit unfamiliar with the domain.
    2222- I did not add integration tests
    2323