Opened 3 years ago

Closed 3 years ago

#18882 closed defect (fixed)

chutney reads the system torrc when generating the router key

Reported by: anonym Owned by: nickm
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords:
Cc: teor Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This can easily be demonstrated by adding an invalid option to /etc/tor/torrc and then running chutney configure. This feels wrong, and will fail if you run a hidden service on the system-wide Tor instance.

Child Tickets

Attachments (2)

do_not_use_system_torrc.patch (1.3 KB) - added by anonym 3 years ago.
0001-Do-not-use-the-system-torrc-when-generating-router-k.patch (1.6 KB) - added by anonym 3 years ago.
Corrected version of the patch.

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by anonym

comment:1 Changed 3 years ago by anonym

The patch I've attached fixes the issue for me. I'm not sure if this is the ideal solution, but feel free to apply it if you think it is good enough.

comment:2 Changed 3 years ago by bertagaz

The last patch had a little mistake: it removed net/.empty, which is wrong. Here's is a corrected version.

comment:3 Changed 3 years ago by teor

Cc: teor added

comment:4 Changed 3 years ago by nickm

Status: newneeds_review

comment:5 Changed 3 years ago by teor

This patch looks sensible to me, but I have yet to test it.

comment:6 Changed 3 years ago by cypherpunks

The patch does not apply cleanly and seems to contain bits from #18826.

Changed 3 years ago by anonym

Corrected version of the patch.

comment:7 in reply to:  6 Changed 3 years ago by anonym

Replying to cypherpunks:

The patch does not apply cleanly and seems to contain bits from #18826.

Sorry for that, should be fixed now!

comment:8 Changed 3 years ago by cypherpunks

Can confirm this does work on my system. I ran into this bug today. Thank you for the fix!

comment:9 Changed 3 years ago by teor

Resolution: fixed
Status: needs_reviewclosed

Thanks for the patch!

Merged to chutney master after testing using a make test-network-all with tor master.

Note: See TracTickets for help on using tickets.