Opened 3 years ago

Last modified 2 years ago

#18888 new defect

we should log an unmistakeable warning when --disable-asserts-in-tests is enabled

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-unit-tests testing disaster-waiting-to-happen
Cc: Actual Points:
Parent ID: Points: .1
Reviewer: Sponsor:

Description

This configuration option has a single valid use case: getting better branch coverage output. Nobody should ever ever use it in production. We should make it warn loudly.

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by cypherpunks

The check on configure.ac:55 seems to warn pretty loudly already as it prints an error message and aborts the configuration phase.

FWIW the Autoconf manual advises that [t]he error-description should start with a lower-case letter, and “cannot” is preferred to “can't”. So the current error message could be improved (on both points).

comment:2 Changed 3 years ago by nickm

The check on ​configure.ac:55 seems to warn pretty loudly already as it prints an error message and aborts the configuration phase.

That message only happens when --disable-asserts-in-tests is enabled but --enable-coverage is not enabled.

I want to make sure that when --disable-asserts-in-tests is enabled AND --enable-coverage is enabled, the generated tor-cov binary warns loudly.

comment:3 Changed 3 years ago by nickm

Points: very small

comment:4 Changed 3 years ago by nickm

Keywords: 029-nickm-says-yes added

marking these as the tickets I am in favor of for 029, among the 029-proposed ones.

comment:5 Changed 3 years ago by nickm

Keywords: 029-proposed 029-nickm-says-yes removed
Milestone: Tor: 0.2.9.x-final

Nobody objected to including any of these, so I guess they are in.

comment:6 Changed 3 years ago by nickm

Points: very small.1

comment:7 Changed 3 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:8 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:9 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:10 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:11 Changed 2 years ago by nickm

Keywords: isaremoved removed

comment:12 Changed 2 years ago by nickm

Keywords: tor-unit-tests testing disaster-waiting-to-happen added
Note: See TracTickets for help on using tickets.