we should log an unmistakeable warning when --disable-asserts-in-tests is enabled

This configuration option has a single valid use case: getting better branch coverage output. Nobody should ever ever use it in production. We should make it warn loudly.

changed milestone to %Tor: unspecified

added component::core tor/tor disaster-waiting-to-happen milestone::Tor: unspecified points::.1 priority::medium severity::normal status::new testing tor-unit-tests type::defect labels

The check on configure.ac:55 seems to warn pretty loudly already as it prints an error message and aborts the configuration phase.

FWIW the Autoconf manual advises that [t]he error-description should start with a lower-case letter, and “cannot” is preferred to “can't”. So the current error message could be improved (on both points).

The check on ​configure.ac:55 seems to warn pretty loudly already as it prints an error message and aborts the configuration phase.

That message only happens when --disable-asserts-in-tests is enabled but --enable-coverage is not enabled.

I want to make sure that when --disable-asserts-in-tests is enabled AND --enable-coverage is enabled, the generated tor-cov binary warns loudly.

Trac:
Points: N/A to very small

marking these as the tickets I am in favor of for 029, among the 029-proposed ones.

Trac:
Keywords: N/A deleted, 029-nickm-says-yes added

Nobody objected to including any of these, so I guess they are in.

Trac:
Milestone: N/A to Tor: 0.2.9.x-final
Keywords: 029-proposed, 029-nickm-says-yes deleted, N/A added

Trac:
Points: very small to .1

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.???
Keywords: N/A deleted, isaremoved added

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Milestone: Tor: 0.3.??? to Tor: unspecified
Keywords: N/A deleted, tor-03-unspecified-201612 added

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: isaremoved deleted, N/A added

Trac:
Keywords: N/A deleted, tor-unit-tests testing disaster-waiting-to-happen added

changed time estimate to 48m

moved to tpo/core/tor#18888 (closed)