Opened 3 years ago

Closed 3 years ago

#18899 closed defect (fixed)

TB 6.0a5 build 3: meek profile gets all extensions

Reported by: mcs Owned by: mcs
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, tbb-6.0a5, TorBrowserTeam201604R
Cc: dcf, gk, brade, mcs, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When the meek helper profile is used for the first time, the browser copies the other bundled extensions into the profile. This causes meek to fail because Tor Launcher starts up and presents the configuration wizard (among other bad things that are happening).

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by mcs

Owner: changed from tbb-team to mcs
Status: newassigned

comment:2 Changed 3 years ago by mcs

Cc: boklm added

comment:3 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201604R added

I believe only Mac OS was affected (due to the #13252 changes).

Here is a fix; please review:
https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug18899-01&id=3b226118fadf42623032b423e41d6803e05901c1

Also, I opened a related ticket: #18904.

comment:4 Changed 3 years ago by mcs

Status: assignedneeds_review

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, looks good. This is commit 3b226118fadf42623032b423e41d6803e05901c1 on master. I applied it to hardened-builds as well (commit 210aa37e48b1bc27f6925f8a4be5d7f47551803e) as it can't hurt and we don't want to forget it.

Note: See TracTickets for help on using tickets.