Opened 3 years ago

Closed 3 years ago

#18905 closed defect (fixed)

Remove unused menu items from Tor Browser help menu

Reported by: arthuredelstein Owned by: arthuredelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff45-esr, TorBrowserTeam201605
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A number of Help menu items in Tor Browser apply only to Firefox or are broken in Tor Browser. In particular:

  • "Tor Browser Help" is actually a help menu for Firefox
  • "Tor Browser Tour" is really a Firefox Tour
  • "Tor Browser Health Report" is a Firefox Health Report to Mozilla that doesn't work on Tor Browser
  • "Submit Feedback..." sends feedback to Mozilla
  • "Restart with Addons Disabled" is inadvisable

So I would suggest removing these menu items.

I have considered the possibility of renaming "Tor Browser Help" and "Tor Browser Tour" to "Firefox Help" and "Firefox Tour" and leaving them in, but I fear this may be confusing to users. More importantly, we should add a menu item with a true "Tor Browser Help"; see #11698.

Child Tickets

Change History (11)

comment:1 Changed 3 years ago by arthuredelstein

Here's a patch:
https://github.com/arthuredelstein/torbutton/commit/18905
Hash: c16df65c79a64e82bdc0e3c10d1b25a49dd04012

comment:2 Changed 3 years ago by arthuredelstein

Keywords: ff45-esr TorBrowserTeam201604R added
Status: newneeds_review

comment:3 Changed 3 years ago by arthuredelstein

Owner: changed from tbb-team to arthuredelstein
Status: needs_reviewassigned

comment:4 Changed 3 years ago by arthuredelstein

Status: assignedneeds_review

comment:5 Changed 3 years ago by mcs

Cc: brade mcs added

comment:6 Changed 3 years ago by bugzilla

"Keyboard Shortcuts" are really Firefox Keyboard Shortcuts
"Report Web Forgery..." is a Firefox Phishing Protection report to Google that doesn't work on Tor Browser

comment:7 Changed 3 years ago by gk

Keywords: TorBrowserTeam201605 added; TorBrowserTeam201604R removed
Status: needs_reviewneeds_revision

I think getting rid of the "Report Web Forgery..." one should be done, too, while we are at it. Otherwise I think doing this can't hurt.

comment:8 in reply to:  7 Changed 3 years ago by arthuredelstein

Replying to gk:

I think getting rid of the "Report Web Forgery..." one should be done, too, while we are at it. Otherwise I think doing this can't hurt.

OK, here's a new version with "Report Web Forgery..." removed:
https://github.com/arthuredelstein/torbutton/commit/cbaa020a454f76e33e25d10952690b54b73eb97a

comment:9 Changed 3 years ago by gk

Alas, this breaks the whole menu as there is code that wants to disable/enable the web forgery item. Removing the element results in

TypeError: document.getElementById(...) is null

in browser-safebrowsing.hs line 17. I guess just collapsing the item would be enough?

comment:10 in reply to:  9 Changed 3 years ago by arthuredelstein

Replying to gk:

Alas, this breaks the whole menu as there is code that wants to disable/enable the web forgery item. Removing the element results in

TypeError: document.getElementById(...) is null

in browser-safebrowsing.hs line 17. I guess just collapsing the item would be enough?

Phooey. Thanks for noticing that error.

I tried using style='display:none' and "hidden='true'" but both fail to make the menu item disappear in OS X. An approach that seems to work for me is to remove the menuitems as before, but then introduce two dummy box elements with the same id. So the code in browser-safebrowsing.hs gets something to chew on.

https://github.com/arthuredelstein/torbutton/commit/a4d4a940b778e8151e649b02041a8f396d9175d0

comment:11 Changed 3 years ago by gk

Resolution: fixed
Status: needs_revisionclosed

Looks good now and is applied to master as commit b72f495c9593bb7df8fab34b642325c22e4e7393, thanks.

Note: See TracTickets for help on using tickets.