Opened 3 years ago

Closed 3 years ago

#18909 closed defect (fixed)

Is time-caching necessary in tor_gettimeofday_cached_monotonic?

Reported by: nickm Owned by:
Priority: High Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 029-nickm-unsure
Cc: mikeperry Actual Points: 0
Parent ID: Points: 1
Reviewer: Sponsor:

Description

Could we instead replace it with reasonably fast time, where reasonably fast is OS-dependent? Or just with tor_gettimeofday()?

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by nickm

Points: small

comment:2 Changed 3 years ago by nickm

Keywords: 029-nickm-unsure added

Marking these tickets as the ones I think I need more feedback about in order to figure out if I think it should go in 0.2.9.

comment:3 Changed 3 years ago by nickm

Poor performance of non-VDSO time means that we're likely to be able to do this only on some systems OR do it only for cases where higher-accuracy time is worth paying for.

comment:4 Changed 3 years ago by nickm

Keywords: 029-proposed removed
Milestone: Tor: 0.2.9.x-final

Calling these "yes for 0.2.9" since a good implementation of mike's padding patches requires them.

comment:5 Changed 3 years ago by nickm

Points: small1
Priority: MediumHigh

comment:6 Changed 3 years ago by nickm

Actual Points: 0
Resolution: fixed
Status: newclosed

tor_gettimeofday_cached_monotonic is dead; see #18908.

Note: See TracTickets for help on using tickets.