Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#18920 closed defect (fixed)

Make consensus GETINFO return 551 when using microdescs

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.2.6-alpha
Severity: Minor Keywords: controller, microdesc, TorCoreTeam201605
Cc: Actual Points: very small
Parent ID: Points: 1
Reviewer: Sponsor:

Description

The tor control-spec says that 551 should be returned for "dir/status" queries where microdescs are in use, and so full descriptors are unavailable.
https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n737

This doesn't happen for dir/status-vote/current/consensus when tor only has a microdesc consensus, instead, tor returns "552 Unrecognized key "dir/status-vote/current/consensus".
https://gitweb.torproject.org/tor.git/tree/src/or/control.c#n2004

The 552 is misleading and not to spec, instead, we should return 551 with a helpful error message.

Credit to s0rlxmh0 for reporting this issue.

Child Tickets

Change History (7)

comment:2 Changed 4 years ago by s0rlxmh0

Status: newneeds_review

comment:3 Changed 4 years ago by teor

Keywords: controller microdesc added
Milestone: Tor: 0.2.???Tor: 0.2.8.x-final
Severity: NormalMinor
Status: needs_reviewmerge_ready
Version: Tor: 0.2.2.6-alpha

Looks great. It's a small change and obviously correct.
Let's merge it in 0.2.8.

This needs a changes file:

  o Minor bugfixes (controller, microdescriptors):
    - Make GETINFO dir/status-vote/current/consensus conform to the control
      specification by returning "551 Could not open cached consensus..."
      when not caching consensuses.
      Fixes bug 18920; bugfix on 0.2.2.6-alpha.

comment:4 Changed 4 years ago by nickm

Keywords: TorCoreTeam201605 added

Calling all non-needs_information tickets for May.

comment:5 Changed 4 years ago by nickm

Actual Points: very small

Merged to maint-0.2.8 as 054d9398531b148d8b41c382da36c83c0381e09e. Thanks!

comment:6 Changed 4 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

comment:7 Changed 4 years ago by isabela

Points: small1
Note: See TracTickets for help on using tickets.