Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18998 closed enhancement (implemented)

Relays should accept RENDEZVOUS1 cells of variable size

Reported by: special Owned by: arma
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs TorCoreTeam201605
Cc: arma Actual Points: 0
Parent ID: #17241 Points: 0
Reviewer: nickm Sponsor:

Description

In rend_mid_rendezvous, we require that the RENDEZVOUS1 cell has precisely DH_KEY_LEN+DIGEST_LEN bytes of handshake info, which is passed verbatim to the service in the RENDEZVOUS2 cell.

For prop 224, we want to use these same cells. Prop 224 redefines RENDEZVOUS1 to be:

RENDEZVOUS_COOKIE [20 bytes]
HANDSHAKE_INFO [variable; to end of cell]

Prop 224's HANDSHAKE_INFO is much shorter. To remain compatible with older RPs, we will need to pad these cells in prop 224. Still, we should start accepting RENDEZVOUS1 cells of any size, and forward everything after the cookie verbatim in the RENDEZVOUS2 cell.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by special

Cc: arma added

comment:2 Changed 3 years ago by arma

Owner: set to arma
Status: newassigned

Check out my feature18998 branch.

comment:3 Changed 3 years ago by nickm

lgtm, waiting for corresponding torspec patch

comment:4 Changed 3 years ago by nickm

Actual Points: 0
Points: 0
Reviewer: nickm

setting points to 0 since arma did this in like 30 minutes top

comment:5 Changed 3 years ago by arma

Status: assignedneeds_review

See my feature18998 torspec branch.

comment:6 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

mergey-mergey

comment:7 Changed 3 years ago by arma

Keywords: TorCoreTeam201605 added
Note: See TracTickets for help on using tickets.